Task 6: Upgrade Test Dependencies (JUnit, REST Assured, json-path)#200
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Task 6: Upgrade Test Dependencies (JUnit, REST Assured, json-path)#200devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
…h 2.9.0 - JUnit: 4.12 -> 4.13.2 (fixes CVE-2020-15250) in ftgo-domain, ftgo-test-util - REST Assured: 2.9.0 -> 5.4.0 in gradle.properties - Updated groupId from com.jayway.restassured to io.rest-assured in ftgo-consumer-service, ftgo-restaurant-service, ftgo-end-to-end-tests-common - Updated hardcoded 3.0.6 versions to use $restAssuredVersion variable in ftgo-order-service, ftgo-courier-service - Updated Java imports from com.jayway.restassured to io.restassured in AbstractEndToEndTests.java - json-path: 2.3.0 -> 2.9.0 in ftgo-consumer-service, ftgo-restaurant-service, ftgo-end-to-end-tests-common Co-Authored-By: Wes Convery <2wconvery@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Open
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades three test dependencies to address security vulnerabilities and modernize the test stack:
JUnit: 4.12 → 4.13.2
ftgo-domain/build.gradle— fixes CVE-2020-15250ftgo-test-util/build.gradleREST Assured: 2.9.0 → 5.4.0
gradle.properties— bumpedrestAssuredVersionto5.4.0com.jayway.restassured→io.rest-assuredin:ftgo-consumer-service/build.gradleftgo-restaurant-service/build.gradleftgo-end-to-end-tests-common/build.gradle3.0.6versions with$restAssuredVersionvariable in:ftgo-order-service/build.gradleftgo-courier-service/build.gradlecom.jayway.restassured.*→io.restassured.*in:AbstractEndToEndTests.javajson-path: 2.3.0 → 2.9.0
ftgo-consumer-service/build.gradleftgo-restaurant-service/build.gradleftgo-end-to-end-tests-common/build.gradleReview & Testing Checklist for Human
RestAssuredConfig/ObjectMapperConfigAPI inAbstractEndToEndTests.javamay have breaking changes (e.g.jackson2ObjectMapperFactorysignature)io.restassuredimport migration works at runtimejson-path 2.9.0doesn't introduce breaking API changes in test assertionsNotes
compileJava/compileTestJavaall pass). Theftgo-end-to-end-tests-commonmodule has a pre-existing unresolvable dependency (eventuate-util-testfrom deprecated jcenter) that prevents its compilation — this is not related to our changes.Link to Devin session: https://app.devin.ai/sessions/44df9588fabb4884bd68df408ce9c3e9
Requested by: @WesternConcrete
Devin Review