Task 2: Upgrade Spring Boot 2.7.18 and Java 17#201
Open
devin-ai-integration[bot] wants to merge 2 commits intomasterfrom
Open
Task 2: Upgrade Spring Boot 2.7.18 and Java 17#201devin-ai-integration[bot] wants to merge 2 commits intomasterfrom
devin-ai-integration[bot] wants to merge 2 commits intomasterfrom
Conversation
- Update springBootVersion from 2.0.3.RELEASE to 2.7.18 - Update springDependencyManagementPluginVersion from 1.0.3.RELEASE to 1.1.4 - Update sourceCompatibility/targetCompatibility from 1.8 to 17 - Upgrade Gradle wrapper from 4.10.2 to 7.6.4 (required by Spring Boot 2.7.x) - Migrate deprecated Gradle configurations: - compile -> api (java-library plugin) - testCompile -> testImplementation - runtime -> runtimeOnly - Update IntegrationTestsPlugin for Gradle 7 API changes Co-Authored-By: Wes Convery <2wconvery@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Add spring.mvc.pathmatch.matching-strategy=ant_path_matcher to fix Springfox 2.8.0 incompatibility with Spring Boot 2.6+ path matching - Update micrometerVersion from 1.0.4 to 1.9.17 to match Spring Boot 2.7.18's managed micrometer-core version Co-Authored-By: Wes Convery <2wconvery@gmail.com>
Open
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the FTGO monolith from Spring Boot 2.0.3 → 2.7.18 (last 2.x release with security patches) and Java 1.8 → Java 17, along with the necessary Gradle infrastructure and compatibility changes.
Changes
gradle.propertiesspringBootVersion2.0.3.RELEASE → 2.7.18,springDependencyManagementPluginVersion1.0.3.RELEASE → 1.1.4,micrometerVersion1.0.4 → 1.9.17build.gradle(root)sourceCompatibility/targetCompatibility1.8 → 17,javaplugin →java-librarygradle/wrapper/gradle-wrapper.propertiesbuildSrc/build.gradlecompile→implementationbuildSrc/.../IntegrationTestsPlugin.groovytestCompile→testImplementation,testClassesDir→testClassesDirs,reports.html.destination→outputLocation)build.gradlefilescompile→api,testCompile→testImplementation,runtime→runtimeOnlyftgo-application/.../application.propertiesspring.mvc.pathmatch.matching-strategy=ant_path_matcherfor Springfox 2.8.0 compatibilityWhy these extra changes were needed
java-library+api: Gradle 7 removed thecompileconfiguration. Usingapi(fromjava-libraryplugin) preserves the original transitive dependency behavior.PathPatternParser, which breaks Springfox 2.x. Addedant_path_matcherworkaround.Build verification
./gradlew clean compileJavapasses for all modules exceptftgo-end-to-end-tests-common, which has a pre-existing dependency resolution failure (io.eventuate.util:eventuate-util-testis unavailable — the eventuate Maven repo was already commented out before this PR).Review & Testing Checklist for Human
./gradlew clean compileJavacompiles successfully (excluding end-to-end test modules which have a pre-existing dependency issue)/swagger-ui.html(Springfox with ant_path_matcher workaround)Notes
ftgo-commonare retained since they're needed for Java 17 (JAXB was removed from the JDK in Java 11+).ant_path_matcherworkaround.Link to Devin session: https://app.devin.ai/sessions/83edc95fe1da47d3992cb0cbe643793e
Requested by: @WesternConcrete
Devin Review