chore(js-ts): migrate app/util/test/ganache.js to TypeScript#595
Open
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Open
chore(js-ts): migrate app/util/test/ganache.js to TypeScript#595devin-ai-integration[bot] wants to merge 2 commits intomainfrom
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Conversation
- Rename ganache.js to ganache.ts - Add proper TypeScript types for class properties, method parameters, and return types - Import EthereumProvider and ServerOptions types from ganache package - Define GanacheOptions type requiring mnemonic field - No import path changes needed (extensionless imports resolve to .ts) Co-Authored-By: shayan <shayan@cognition.ai>
Devin Review
|
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Address Devin Review feedback: replace optional chaining with explicit null checks in getAccounts() and getBalance() to throw clear errors when the provider is absent, matching the original JS behavior. Co-Authored-By: shayan <shayan@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates
app/util/test/ganache.jsfrom JavaScript to TypeScript.Changes:
ganache.js→ganache.tsEthereumProviderandServerOptionstypes from theganachepackageGanacheOptionstype that extendsServerOptions<'ethereum'>with a requiredmnemonicfield_serverproperty usingReturnType<typeof ganache.server>getAccounts()andgetBalance()to preserve the original fail-fast behavior (instead of silently returningundefined/NaNvia optional chaining).tsautomaticallyReview & Testing Checklist for Human
ganachepackage exportsEthereumProviderandServerOptionstypes correctly (ganache v7.9.2)Notes
e2e/fixtures/utils.js,e2e/fixtures/fixture-helper.js,wdio/utils/ganache.js) — all use extensionless import paths so no changes are requiredGanacheOptionstype enforces themnemonicfield at the type level, matching the existing runtime checkLink to Devin session: https://app.devin.ai/sessions/7a79f1cc0e8c4fd3bef7dacb53bf19e5
Requested by: @shayanshafii