fix(deps): add sharp resolution to fix heap buffer overflow CVE#603
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
fix(deps): add sharp resolution to fix heap buffer overflow CVE#603devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Add yarn resolution for sharp >= 0.33.0 to mitigate SNYK-JS-SHARP-5922108 (Heap-based Buffer Overflow, CVSS 9.8). The vulnerable sharp@0.32.5 was introduced transitively via appium-adb's @appium/support dependency. This resolution forces all sharp instances to resolve to 0.33.5, which contains the fix. Co-Authored-By: Abhay Aggarwal <abhay.aggarwal@codeium.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a yarn resolution
"**/sharp": ">=0.33.0"to fix SNYK-JS-SHARP-5922108 — a heap-based buffer overflow vulnerability in sharp (CVSS 9.8).The vulnerable
sharp@0.32.5was introduced transitively viaappium-adb→@appium/support→sharp. This resolution forces allsharpinstances to resolve to0.33.5, which contains the fix.Changes:
package.json: Added"**/sharp": ">=0.33.0"to the existingresolutionsblockyarn.lock: Removed the standalonesharp@0.32.5entry and redirected it to thesharp@0.33.5entryReview & Testing Checklist for Human
yarn installcompletes without peer dependency conflicts related to sharp (sharp 0.33.x drops some legacy APIs;appium-adbonly uses sharp transitively via@appium/supportfor image operations in device testing)yarn auditor Snyk scan to confirm SNYK-JS-SHARP-5922108 is resolvedNotes
sharpis only used in dev/test paths (appium-adb, react-native-svg-asset-plugin), so this should have zero impact on the production app bundle.yarnrchasignore-scripts true, so sharp's native binaries won't be compiled during install — they're fetched as prebuilt binaries via optional@img/sharp-*packagesyarn installcould not run locally due to a pre-existing 404 onreact-native-tcpGitHub tarball; the yarn.lock was updated manually to match what yarn would produce with the resolution appliedLink to Devin session: https://app.devin.ai/sessions/4e23d96e940b4c31a5a329c0ae40aceb
Requested by: @abhay-codeium
Devin Review