fix(deps): add node-forge resolution to fix 6 CVEs including 2 critical#606
Open
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Open
fix(deps): add node-forge resolution to fix 6 CVEs including 2 critical#606devin-ai-integration[bot] wants to merge 2 commits intomainfrom
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Conversation
Add yarn resolution for node-forge ^1.4.0 to address: - CVE-2026-33893 (Critical, CVSS 9.4): Improper Certificate Validation - CVE-2025-66029 (Critical, CVSS 9.3): Interpretation Conflict - CVE-2026-33895 (High): Additional vulnerability - CVE-2026-33891 (High): Additional vulnerability - CVE-2026-33894 (High): Additional vulnerability - CVE-2025-66031 (High): Additional vulnerability The transitive dependency via mockttp > node-forge was at 1.3.1. This resolution forces all instances to use ^1.4.0. Co-Authored-By: Abhay Aggarwal <abhay.aggarwal@codeium.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Co-Authored-By: Abhay Aggarwal <abhay.aggarwal@codeium.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a yarn resolution
"**/node-forge": "^1.4.0"to force-upgradenode-forgefrom 1.3.1 to 1.4.0 across all transitive dependency paths (primarilymockttp > node-forge).This fixes 6 CVEs:
Changes
package.json: Added"**/node-forge": "^1.4.0"to the existingresolutionsblock (45th resolution entry)yarn.lock: Updatednode-forgefrom 1.3.1 → 1.4.0 with correct registry URL and integrity hashCompatibility
mockttp@^3.15.2depends onnode-forge@^1.2.1— fully satisfied by 1.4.0@expo/config-plugins,selfsigned) also use^1.2.1or^1.3.1ranges — all compatible with 1.4.0Review & Testing Checklist for Human
node-forgeresolves to 1.4.0 after runningyarn installand checkingyarn why node-forgeNotes
react-native-tcpGitHub tarball returns 404 (aprock/react-native-tcprepo/commit no longer accessible) — this blocksyarn installin CI for unit-tests, dedupe, git-safe-dependencies, audit, and js-bundle-size-check jobsCLABot: missingcla-signaturesbranch in the forkcheck-pr-labels: missing required team/QA labels (expected for bot PRs)check-diff: Ruby 3.1.6 not available on macOS self-hosted runnercheck-pr-labelsjob ranyarn --immutablesuccessfully (Done in 2.95s), confirming the yarn.lock is valid and consistentLink to Devin session: https://app.devin.ai/sessions/0306cfe62b864f8fa23f2a6e61a487c7
Requested by: @abhay-codeium
Devin Review