fix(deps): add sha.js resolution to fix SNYK-JS-SHAJS-12089400#607
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
fix(deps): add sha.js resolution to fix SNYK-JS-SHAJS-12089400#607devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Add yarn resolution for sha.js ^2.4.12 to address critical vulnerability SNYK-JS-SHAJS-12089400 (Function Call With Incorrect Argument Type, CVSS 9.8). The vulnerable version 2.4.11 was pulled in transitively via @ngraveio/bc-ur > sha.js. The resolution forces all instances of sha.js to resolve to >=2.4.12. Co-Authored-By: Abhay Aggarwal <abhay.aggarwal@codeium.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a yarn resolution for
sha.jsto fix critical vulnerability SNYK-JS-SHAJS-12089400 (Function Call With Incorrect Argument Type, CVSS 9.8).What changed:
"**/sha.js": "^2.4.12"to theresolutionsfield inpackage.jsonyarn.lockto resolvesha.jsto version2.4.12(previously2.4.11)Why:
The vulnerable version
sha.js@2.4.11was pulled in transitively via@ngraveio/bc-ur→sha.js. The resolution forces all instances ofsha.jsacross the dependency tree to resolve to>=2.4.12, which contains the fix.Impact:
@ngraveio/bc-ur@1.1.13(QR code hardware wallet communication) depends onsha.js@^2.4.11, which is satisfied by2.4.12— no breaking change expected.sha.js@2.4.12is a patch-level semver update.Review & Testing Checklist for Human
yarn installsucceeds in CI andsha.jsresolves to2.4.12@ngraveio/bc-ur) still function correctlyNotes
yarn installcould not complete locally due to a pre-existing 404 onreact-native-tcpGitHub tarball (unrelated to this change). Theyarn.lockwas updated manually with the correct integrity hash from the npm registry.ignore-scripts truein.yarnrc.Link to Devin session: https://app.devin.ai/sessions/bf60714f26b64bd7a95d0ef09407df98
Requested by: @abhay-codeium
Devin Review