Skip to content

fix(deps): add basic-ftp resolution to fix CRLF injection CVE#609

Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin/1777470482-fix-basic-ftp-cve
Open

fix(deps): add basic-ftp resolution to fix CRLF injection CVE#609
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin/1777470482-fix-basic-ftp-cve

Conversation

@devin-ai-integration
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot commented Apr 29, 2026

Summary

Adds a yarn resolution for basic-ftp to fix SNYK-JS-BASICFTP-15953339 (CRLF Injection, CVSS 9.3).

  • Current version: 5.0.3 (transitive via mockttppac-proxy-agentget-uribasic-ftp)
  • Fixed version: 5.0.5 (resolution forces ^5.0.4)
  • CVE: SNYK-JS-BASICFTP-15953339

Changes:

  1. Added "**/basic-ftp": "^5.0.4" to the resolutions field in package.json
  2. Updated yarn.lock to resolve basic-ftp to 5.0.5 (from 5.0.3)

This is a patch version bump with very low risk. The basic-ftp package is deep in the transitive dependency tree and is not used directly by the application.

Review & Testing Checklist for Human

  • Verify the resolution entry in package.json is correct: "**/basic-ftp": "^5.0.4"
  • Verify yarn.lock shows basic-ftp at version 5.0.5 (not 5.0.3)
  • Run yarn install in a clean environment to confirm lockfile integrity

Notes

  • yarn install could not be run locally due to a pre-existing 404 on react-native-tcp (the GitHub tarball at aprock/react-native-tcp#98fbc801... returns 404). This is unrelated to this change. The yarn.lock was updated manually to reflect the resolution.
  • The project already has 44 other resolutions in package.json following the same pattern.

Link to Devin session: https://app.devin.ai/sessions/c0029f92d53b4c4cae513b691dc39526
Requested by: @abhay-codeium


Devin Review

Status Commit
⚪ Not started

💡 Connect your GitHub account to enable automatic code reviews.

Open in Devin Review (Staging)
Open in Devin Review

Add yarn resolution for basic-ftp ^5.0.4 to address
SNYK-JS-BASICFTP-15953339 (CRLF Injection, CVSS 9.3).

basic-ftp is a transitive dependency via:
mockttp -> pac-proxy-agent -> get-uri -> basic-ftp

Bumps basic-ftp from 5.0.3 to 5.0.5.

Co-Authored-By: Abhay Aggarwal <abhay.aggarwal@codeium.com>
@devin-ai-integration
Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link
Copy Markdown
Author

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant