chore(js-ts): Convert all Redux actions and reducers to TypeScript#611
Open
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Open
chore(js-ts): Convert all Redux actions and reducers to TypeScript#611devin-ai-integration[bot] wants to merge 2 commits intomainfrom
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Conversation
Convert all 11 Redux action files in app/actions/ from JavaScript to TypeScript: - alert, bookmarks, browser, collectibles, infuraAvailability - modals, notification, privacy, settings, transaction, wizard For each file: - Renamed .js to .ts - Added string literal type constants with 'as const' - Defined discriminated union Action types - Added explicit parameter types and return types to all action creators - Exported Action union types for use by reducers Follows the pattern established in app/actions/onboarding/index.ts Co-Authored-By: Luke Page <luke.page@cognition.ai>
Convert all 12 Redux reducer files in app/reducers/ from JavaScript to TypeScript: - alert, bookmarks, browser, collectibles, infuraAvailability - modals, notification, privacy, settings, swaps, transaction, wizard For each reducer: - Renamed .js to .ts - Defined State interfaces for all reducer state shapes - Imported Action union types from corresponding action files - Typed reducer function signatures with proper State and Action types - Exported State interfaces for use in RootState Updated app/reducers/index.ts RootState interface: - Replaced 'any' with proper State types for all 12 converted reducers - Removed corresponding TODO comments and eslint-disable comments - Added imports for all new State types Co-Authored-By: Luke Page <luke.page@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts all 23 remaining JavaScript Redux action and reducer files to TypeScript as part of the JS→TS migration effort.
Actions converted (11 files):
app/actions/alert,bookmarks,browser,collectibles,infuraAvailabilityapp/actions/modals,notification,privacy,settings,transaction,wizardFor each action file:
as conststring literal typesAlertAction,BrowserAction)app/actions/onboarding/index.tsReducers converted (12 files):
app/reducers/alert,bookmarks,browser,collectibles,infuraAvailabilityapp/reducers/modals,notification,privacy,settings,swaps,transaction,wizardFor each reducer file:
AlertState,BrowserState,SwapsState)(state: XState, action: XAction) => XStateRootState updated:
anytypes with proper State interfaces inapp/reducers/index.ts// TODO: Replace "any" with typeandeslint-disablecommentsReview & Testing Checklist for Human
initialStateobjectsyarn tsc --noEmityarn test --findRelatedTestson a few key files to confirm test compatibilityNotes
swaps/index.tsreducer is the most complex conversion with manycreateSelectorcalls and dynamic chain-ID-keyed state@typescript-eslint/default-param-lasteslint-disable is preserved in reducer files since Redux reducers require(state = initialState, action)signatureLink to Devin session: https://app.devin.ai/sessions/51734166b8b740daa75579e47f5a94be
Requested by: @lukepage-COG
Devin Review