chore(js-ts): Convert constants and utility files to TypeScript#612
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
chore(js-ts): Convert constants and utility files to TypeScript#612devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Convert 3 constants files: - app/constants/navigation.ts (pure string exports) - app/constants/network.ts (network constants, chain IDs) - app/constants/onboarding.ts (onboarding step constants) Convert 6 utility files: - app/util/date/index.ts (date formatting functions) - app/util/scaling.ts (screen scaling utilities) - app/util/dapp-url-list.ts (DApp URL list data) - app/util/confusables/index.ts (ENS confusables detection) - app/util/etherscan.ts (etherscan URL helpers) - app/util/middlewares.ts (RPC middleware factories) All functions annotated with explicit parameter and return types. No logic or behavioral changes. Co-Authored-By: Luke Page <luke.page@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts 9 foundational JS files (3 constants + 6 utilities) to TypeScript as part of the incremental JS→TS migration.
Constants (3 files):
app/constants/navigation.ts— pure string constant exports (no code changes needed)app/constants/network.ts— network names, chain IDs, currency symbol mappings (no code changes needed)app/constants/onboarding.ts— onboarding step constants (no code changes needed)Utilities (6 files):
app/util/date/index.ts— date formatting functions, added parameter/return typesapp/util/scaling.ts— screen scaling utilities, addedScaleOptionsinterfaceapp/util/dapp-url-list.ts— static DApp URL list (no code changes needed)app/util/confusables/index.ts— ENS confusables detection, added parameter/return typesapp/util/etherscan.ts— etherscan URL helpers, added parameter/return typesapp/util/middlewares.ts— RPC middleware factories, addedRpcRequest/RpcResponseinterfacesReview & Testing Checklist for Human
app/constants/network.tsexports are still consumed correctly by downstream files (widely imported)yarn test --findRelatedTestson a few of the converted files to confirm test compatibilityNotes
Link to Devin session: https://app.devin.ai/sessions/51734166b8b740daa75579e47f5a94be
Requested by: @lukepage-COG
Devin Review