chore: migrate app/util/test/ganache.js to TypeScript#617
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
chore: migrate app/util/test/ganache.js to TypeScript#617devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
- Rename ganache.js to ganache.ts
- Add typed private _server field
- Type start() opts parameter with GanacheStartOptions (ServerOptions & { mnemonic: string })
- Type getProvider() return as EthereumProvider | undefined
- Type getAccounts() return as Promise<string[]>
- Type getBalance() return as Promise<number | string>
- Type quit() return as Promise<void>
- Add null checks for provider access with proper error messages
Co-Authored-By: shayan <shayan@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates
app/util/test/ganache.jsfrom JavaScript to TypeScript as part of the ongoing JS→TS migration effort.Changes:
ganache.js→ganache.ts_serverfield with proper type (ReturnType<typeof ganache.server> | undefined)GanacheStartOptionstype asServerOptions & { mnemonic: string }to enforce the required mnemonicgetProvider()return asEthereumProvider | undefinedgetAccounts()return asPromise<string[]>with a null guard on the providergetBalance()return asPromise<number | string>with a null guard on the providerquit()return asPromise<void>EthereumProviderandServerOptionstypes fromganacheImporters (
e2e/fixtures/fixture-helper.js,e2e/fixtures/utils.js,wdio/utils/ganache.js) are unaffected since TypeScript's module resolution resolves.tsfiles from extensionless imports.Review & Testing Checklist for Human
GanacheStartOptionstype (ServerOptions & { mnemonic: string }) is compatible with all call sites (e.g.,fixture-helper.jspassingdefaultGanacheOptions)yarn test --findRelatedTests app/util/test/ganache.tsNotes
ganachepackage is declared as a dependency (^7.9.2) but may not be installed locally due to a knownyarn installissue with a deleted transitive dependency. Types were verified against the publishedganache@7.9.2type definitions..jsfiles and use extensionless imports, so no import path updates are needed.Link to Devin session: https://app.devin.ai/sessions/41ca62da4ea54ade943272546ffc8a03
Requested by: @shayanshafii
Devin Review