Add GitHub Actions CI workflow for Java 17#546
Open
devin-ai-integration[bot] wants to merge 3 commits intomasterfrom
Open
Add GitHub Actions CI workflow for Java 17#546devin-ai-integration[bot] wants to merge 3 commits intomasterfrom
devin-ai-integration[bot] wants to merge 3 commits intomasterfrom
Conversation
Co-Authored-By: shayan <shayan@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: shayan <shayan@cognition.ai>
Co-Authored-By: shayan <shayan@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The repository had no CI/CD configuration files. This PR adds a GitHub Actions workflow (
.github/workflows/build.yml) that builds and tests the project on every push and pull request tomaster, using JDK 17 (Temurin distribution).The workflow:
actions/setup-java@v4gradle/actions/setup-gradle@v4./gradlew build -x spotlessJava -x spotlessCheckSpotless checks (
spotlessJava,spotlessCheck) are excluded because the repo usescom.diffplug.spotlessv6.2.1 withgoogleJavaFormat(), which is incompatible with JDK 17 (crashes withInvocationTargetExceptiondue to missing--add-exportsforjdk.compilerinternals). Fixing this would require upgrading Spotless inbuild.gradle, which is out of scope for this PR.Note:
build.gradlestill hassourceCompatibility = '11'/targetCompatibility = '11'. This is intentional — only CI/CD files were in scope. JDK 17 can compile Java 11 targets without issue.Review & Testing Checklist for Human
build.gradle(separate PR)sourceCompatibility = '11'inbuild.gradlewhile CI uses JDK 17 (this works, but if a full Java 17 migration is planned,build.gradlewould need updating separately)Notes
.travis.yml,Jenkinsfile,Dockerfile,.circleci/config.yml, etc.) were found in the repository.buildtask includestestin its default lifecycle, so tests are executed as part of the single./gradlew buildcommand.Link to Devin session: https://app.devin.ai/sessions/7bee749b31de4e2f98235117e573f4e7
Requested by: @shayanshafii