Update build.gradle Java version to 17 and Gradle wrapper to 7.6.1#551
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Update build.gradle Java version to 17 and Gradle wrapper to 7.6.1#551devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
- Change sourceCompatibility from 11 to 17 - Change targetCompatibility from 11 to 17 - Upgrade Gradle wrapper from 7.4 to 7.6.1 Co-Authored-By: shayan <shayan@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the project's Java source/target compatibility from 11 to 17 and upgrades the Gradle wrapper from 7.4 to 7.6.1 (which has full Java 17 support).
Changes:
build.gradle:sourceCompatibilityandtargetCompatibilitychanged from'11'to'17'./gradlew wrapper --gradle-version=7.6.1(run twice per Gradle docs to update the wrapper itself)gradlew,gradlew.bat,gradle-wrapper.jar, andgradle-wrapper.propertiesare all auto-generated by the wrapper upgrade — no manual editsNo dependency versions were changed — that is being handled in a separate session.
Build status:
./gradlew compileJavasucceeds../gradlew buildfails on thespotlessJavatask because the current version ofcom.diffplug.spotless/ Google Java Format uses JDK internals (com.sun.tools.javac.parser) that Java 17's module system blocks. This is a pre-existing dependency compatibility issue, not caused by this PR.Review & Testing Checklist for Human
sourceCompatibility,targetCompatibility, and wrapper version changed inbuild.gradle— no dependency versions were modified./gradlew buildwill fail onspotlessJavauntil the Spotless plugin is upgraded (separate effort) — Java compilation itself works fineNotes
gradlew/gradlew.batdiffs look large but are entirely auto-generated by Gradle 7.6.1's wrapper task (improved POSIX compliance, better quoting, etc.)./gradlew buildpassing end-to-endLink to Devin session: https://app.devin.ai/sessions/7317925a7b4e4fc384fb541dd6522c47
Requested by: @shayanshafii