Fix raw types in UpdateUserConstraint and document Java 17 API review#554
Open
devin-ai-integration[bot] wants to merge 3 commits intomasterfrom
Open
Fix raw types in UpdateUserConstraint and document Java 17 API review#554devin-ai-integration[bot] wants to merge 3 commits intomasterfrom
devin-ai-integration[bot] wants to merge 3 commits intomasterfrom
Conversation
…or Java 17 Migrated all javax.validation imports to jakarta.validation namespace across 11 files in the application layer. This is the primary change needed for Java 17 compatibility, as Spring Boot 3.x (which requires Java 17+) uses the Jakarta EE 9+ namespace. Review findings: - No javax.security.auth.Subject.doAs() usage found - No SecurityManager usage found - No Nashorn JavaScript engine usage found - No illegal reflection access found - No java.util.Date patterns that changed found Files changed: - article/ArticleCommandService.java - article/DuplicatedArticleConstraint.java - article/DuplicatedArticleValidator.java - article/NewArticleParam.java - user/DuplicatedEmailConstraint.java - user/DuplicatedEmailValidator.java - user/DuplicatedUsernameConstraint.java - user/DuplicatedUsernameValidator.java - user/RegisterParam.java - user/UpdateUserParam.java - user/UserService.java Co-Authored-By: shayan <shayan@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
… layer for Java 17" This reverts commit 80acfae.
Replace raw Class[] types with properly parameterized Class<?>[] and Class<? extends Payload>[] in the UpdateUserConstraint annotation to match the Bean Validation contract and eliminate raw type warnings. This was the only code quality issue found during the Java 17 API review of the application layer. No Java 17 deprecated/removed APIs (Subject.doAs, SecurityManager, Nashorn, illegal reflection, etc.) were found in any of the 30 reviewed files. Co-Authored-By: shayan <shayan@cognition.ai>
devin-ai-integration
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewed all 30 Java files under
src/main/java/io/spring/application/for deprecated/removed Java 17 APIs. No issues were found for:javax.security.auth.Subject.doAs()SecurityManagerusagejava.util.Datebehavioral changesThe only code fix is in
UserService.java: theUpdateUserConstraintannotation used rawClass[]types forgroups()andpayload(), which should beClass<?>[]andClass<? extends Payload>[]per the Bean Validation contract. This eliminates raw type compiler warnings.Review & Testing Checklist for Human
UpdateUserConstraintcompiles correctly (./gradlew compileJava)javax.validation→jakarta.validationmigration at that time (along with files inapi/,graphql/, and other packages)Notes
src/main/java/io/spring/application/user/UserService.javawas modified; no other application-layer files required changes.build.gradleand test files were not modified per task scoping.Link to Devin session: https://app.devin.ai/sessions/00c601670ca44b6f9b6580706c90454e
Requested by: @shayanshafii