Upgrade Spring Boot and dependency versions for Java 17 compatibility#557
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Upgrade Spring Boot and dependency versions for Java 17 compatibility#557devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
- Spring Boot: 2.6.3 → 2.7.18 - io.spring.dependency-management: 1.0.11.RELEASE → 1.1.4 - Netflix DGS codegen plugin: 5.0.6 → 5.6.7 - Netflix DGS framework: 4.9.21 → 5.5.1 - MyBatis Spring Boot starter: 2.2.2 → 2.3.2 - jjwt (api/impl/jackson): 0.11.2 → 0.11.5 - sqlite-jdbc: 3.36.0.3 → 3.42.0.0 - rest-assured: 4.5.1 → 5.3.2 - spotless: 6.2.1 → 6.22.0 - joda-time: 2.10.13 → 2.12.5 - Add settings.gradle with pluginManagement for Maven Central resolution - Fix PageInfo type incompatibility caused by DGS upgrade - Apply spotless formatting fixes Co-Authored-By: shayan <shayan@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades Spring Boot from 2.6.3 → 2.7.18 and all major dependencies to Java 17-compatible versions, staying on Spring Boot 2.7.x to avoid the javax→jakarta migration required by 3.x.
Dependency upgrades:
Code changes required by DGS upgrade:
ArticleDatafetcher.javaandCommentDatafetcher.java: Migrated fromgraphql.relay.DefaultPageInfo/graphql.relay.PageInfoto DGS-codegen-generatedio.spring.graphql.types.PageInfo, using its builder API (startCursor,endCursor,hasPreviousPage,hasNextPage).Infrastructure:
settings.gradlewithpluginManagementblock to resolve DGS codegen plugin dependencies from Maven Central (required because the codegen core artifact is not hosted on the Gradle Plugin Portal).Build status: Compilation and spotless checks pass. Tests have 37 failures due to
NoSuchMethodErrorinFederation.java:194(DGS framework runtime incompatibility), which is expected per task spec.Review & Testing Checklist for Human
5.6.8but that version's core artifact is missing from Maven Central (jumps 5.6.7 → 5.6.9). This PR uses5.6.7— verify this is acceptable or if5.6.9is preferred.io.spring.graphql.types.PageInfotype hashasPreviousPage/hasNextPagefields (nothasPrevious/hasNext). Incorrect mapping would compile but produce wrong GraphQL responses.NoSuchMethodErroratFederation.java:194, indicating a DGS 5.5.1 runtime incompatibility. Confirm this is expected to be addressed separately, or whether a different DGS framework version (e.g., 5.5.0 or 4.x latest) would avoid this.rootProject.name = 'spring-boot-realworld-example-app'matches expectations and that thepluginManagementblock doesn't interfere with other build configurations.Recommended test plan: Run
./gradlew compileJava compileTestJava spotlessCheckto confirm compilation. Run./gradlew testand verify failures are limited to the known DGSFederationissue. Boot the app with./gradlew bootRunand confirm it starts without errors.Notes
sourceCompatibility/targetCompatibilityand the Gradle wrapper version are intentionally not changed — handled by separate sessions.DefaultJwtServiceTest.javachange is a spotless auto-format (line wrapping), no logic change.Link to Devin session: https://app.devin.ai/sessions/17f55f06fe54418082f66fc31b983f8d
Requested by: @shayanshafii