Migrate from Java 11 to Java 17 with Spring Boot 2.7.18#561
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Migrate from Java 11 to Java 17 with Spring Boot 2.7.18#561devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
- Update sourceCompatibility/targetCompatibility to Java 17 - Upgrade Spring Boot 2.6.3 -> 2.7.18 - Upgrade Spring dependency-management 1.0.11 -> 1.0.15 - Upgrade DGS codegen 5.0.6 -> 5.12.4 - Upgrade DGS starter 4.9.21 -> 5.5.1 with platform BOM - Upgrade Spotless 6.2.1 -> 6.25.0 with googleJavaFormat 1.17.0 - Upgrade Gradle wrapper 7.4 -> 7.6.4 - Upgrade mybatis-spring-boot-starter 2.2.2 -> 2.3.2 - Upgrade sqlite-jdbc 3.36.0.3 -> 3.42.0.1 - Upgrade jjwt 0.11.2 -> 0.11.5 - Upgrade joda-time 2.10.13 -> 2.12.5 - Upgrade rest-assured 4.5.1 -> 5.3.2 - Refactor WebSecurityConfig: replace deprecated WebSecurityConfigurerAdapter with SecurityFilterChain bean - Migrate PageInfo from graphql-relay to DGS-generated types - Add dependencyManagement overrides for graphql-java and rest-assured Co-Authored-By: Kyu Choi <kyuhwanchoi0423@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the project from Java 11 to Java 17, with Spring Boot 2.6.3 → 2.7.18 and all associated dependency bumps. Key changes:
sourceCompatibility/targetCompatibilityset to'17',--release 17compiler arg addedWebSecurityConfigurerAdapter; replaced with a@Bean SecurityFilterChainmethod (standard Spring Security 5.7+ pattern)PageInfofromgraphql.relay.DefaultPageInfoto the DGS-generatedio.spring.graphql.types.PageInfoin bothArticleDatafetcherandCommentDatafetchergoogleJavaFormat('1.17.0')pinned for Java 17 module access compatibilitydependencyManagementblock to forcegraphql-java:19.2andrest-assured:5.3.2— Spring Boot's BOM was downgrading these transitive dependencies, causingNoSuchMethodErrorat runtimeAll 68 tests pass locally with
./gradlew clean build.Review & Testing Checklist for Human
dependencyManagementoverrides are safe: Thegraphql-java:19.2andrest-assured:5.3.2forced versions override Spring Boot's managed versions. Confirm these don't introduce transitive conflicts in production (not just tests). Consider whether the DGS platform BOM (graphql-dgs-platform-dependencies:5.5.1) on line 52 is redundant with thedependencyManagementblock override on line 33.ArticleDatafetcherandCommentDatafetchernow useio.spring.graphql.types.PageInfo(DGS-generated) instead ofgraphql.relay.DefaultPageInfo. Verify the generated type's field names (startCursor,endCursor,hasPreviousPage,hasNextPage) match the GraphQL schema and produce correct responses for clients.WebSecurityConfigrefactor preserves all existing rules (CSRF disabled, stateless sessions, URL auth patterns, CORS, JWT filter). Confirm authorization behavior is identical — especially the ordering ofantMatchersand that/articles/feed(GET, authenticated) still takes precedence over/articles/**(GET, permitAll)../gradlew bootRunand exercise the REST and GraphQL APIs to confirm runtime behavior beyond unit tests (e.g., JWT auth flow, article CRUD, GraphQL pagination withpageInfo).Notes
gradlewscript diff is large but entirely auto-generated by./gradlew wrapper --gradle-version 7.6.4— no manual edits.javax.*imports are unchanged; those only need to migrate tojakarta.*for Spring Boot 3.x.Link to Devin session: https://app.devin.ai/sessions/b302e00daffe497f95431a39cb827fc4
Requested by: @choikh0423