Upgrade Java 11 + Spring Boot 2.6.3 → Java 17 + Spring Boot 3.2.5#563
Open
devin-ai-integration[bot] wants to merge 8 commits intomasterfrom
Open
Upgrade Java 11 + Spring Boot 2.6.3 → Java 17 + Spring Boot 3.2.5#563devin-ai-integration[bot] wants to merge 8 commits intomasterfrom
devin-ai-integration[bot] wants to merge 8 commits intomasterfrom
Conversation
- Added a simple note confirming RealWorld API spec compliance - This is a test change to verify PR workflow functionality Co-Authored-By: Gardner Johnson <gardnerjohnson@gmail.com>
…st-dummy-change Test: Add testing verification note to README
- Modern React 18 frontend with TypeScript and Tailwind CSS - Complete RealWorld specification implementation - User authentication with JWT token management - Article management (create, view, edit, delete) - Article feed with pagination - User profiles and following functionality - Comments system for articles - Social features (favorites, following) - Tag-based article categorization - Responsive design with modern UI - Full API integration with Spring Boot backend - Development server on localhost:3000 - Production build support Features implemented: - User registration and login - Article creation and editing with markdown support - Global article feed - User profiles and social following - Comment system - Article favoriting - Tag filtering - JWT authentication integration - Error handling and validation - Modern responsive UI design The frontend successfully demonstrates all backend API functionality through a visual web interface, replacing raw JSON responses with a complete social blogging platform user experience. Co-Authored-By: Gardner Johnson <gardnerjohnson@gmail.com>
- Remove node_modules from git tracking and add to .gitignore - Configure environment variables for API base URL using VITE_API_BASE_URL - Add TypeScript definitions for Vite environment variables - Remove unused 'User' import to fix TypeScript error Addresses the 5 critical issues identified in PR review: 1. ✅ Remove node_modules from git (added to .gitignore) 2. 🔄 Test complete user journey (next step) 3. ✅ Configure environment variables (VITE_API_BASE_URL) 4. 🔄 Verify CORS configuration (next step) 5. 🔄 Test authentication flow thoroughly (next step) Co-Authored-By: Gardner Johnson <gardnerjohnson@gmail.com>
…d-react-frontend Add React Frontend Application for RealWorld API
- Update build.gradle: Spring Boot 3.2.5, dependency-management 1.1.5, DGS codegen 6.2.1, Spotless 6.25.0, Java 17, MyBatis 3.0.3, DGS 8.5.0 with platform BOM, jjwt 0.12.5, SQLite 3.45.3.0, rest-assured 5.4.0, jackson-datatype-jsr310 - Migrate javax.* to jakarta.* namespace (validation + servlet) - Rewrite WebSecurityConfig for Spring Security 6 (SecurityFilterChain) - Fix CustomizeExceptionHandler signature (HttpStatusCode) - Migrate Joda-Time DateTime to java.time.Instant - Update jjwt 0.12 API (subject, expiration, signWith, parseSignedClaims) - Upgrade Netflix DGS 8.x (handleException, SimpleDataFetcherExceptionHandler) - Java 17 optimizations: records, pattern matching instanceof, Stream.toList(), Map.of(), remove Util.java - Update Gradle wrapper 7.4 to 8.7 - Update GitHub Actions workflow for Java 17 - Fix DGS PageInfo type conversion (graphql.relay -> DGS generated types) - All 69 tests passing Co-Authored-By: Stephen Cornwell <stephen@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Stephen Cornwell <stephen@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive migration from Java 11 / Spring Boot 2.6.3 to Java 17 / Spring Boot 3.2.5. This touches 58 files across the entire codebase.
Infrastructure & build:
mustRunAfterordering to satisfy Gradle 8.7's stricter task dependency validationFramework migration:
javax.validation/javax.servlet→jakarta.validation/jakarta.servletWebSecurityConfigurerAdapterremoved; replaced withSecurityFilterChainbean (antMatchers→requestMatchers,authorizeRequests→authorizeHttpRequests)CustomizeExceptionHandler.handleMethodArgumentNotValidparameter changed fromHttpStatus→HttpStatusCodeLibrary upgrades:
subject(),expiration(),signWith(key, alg),parseSignedClaims(),getPayload())onException→handleExceptionreturningCompletableFuture,DefaultDataFetcherExceptionHandler→SimpleDataFetcherExceptionHandler,graphql.relay.DefaultPageInfo→ DGS-generatedPageInfo)Joda-Time → java.time:
org.joda.time.DateTime→java.time.Instant(entities, DTOs, cursors, type handlers, tests)DateTimeSerializer; replaced withjackson-datatype-jsr310(JavaTimeModule)DateTimeHandler(MyBatis) rewritten to useTimestamp.from(instant)/toInstant()joda-timedependency entirelyJava 17 idioms:
ArticleDataList,ArticleFavoriteCount,FieldErrorResource,UserWithToken,UpdateUserCommandinstanceofin GraphQL exception handler,SecurityUtil,UserMutation,MeDatafetcherCollectors.toList()→Stream.toList(), anonymousHashMapsubclasses →Map.of()Util.java; replaced usages with inline null/empty checksAll 69 tests pass locally.
spotlessApplyapplied.Review & Testing Checklist for Human
DateTimeSerializeremitted ISO-8601 strings ("2024-01-01T00:00:00.000Z"). The replacementJavaTimeModuleserializesInstantas epoch seconds by default (a number, not a string). UnlessWRITE_DATES_AS_TIMESTAMPSis disabled on theObjectMapper, all date/time fields in REST and GraphQL responses will change format, breaking API consumers. Verify the JSON output format matches the RealWorld spec expectations — you may need to addspring.jackson.serialization.write-dates-as-timestamps=falsetoapplication.properties.jwt.secretinapplication.properties(or env override) meets this minimum — the app will throwWeakKeyExceptionat startup otherwise.WebSecurityConfigrewrite uses.cors(Customizer.withDefaults()), which requires aCorsConfigurationSourcebean to be defined — verify the old CORS config bean was not dropped. Also confirm/articles/feedstill requires auth, andGET /articles/**,GET /profiles/**,GET /tagsremain public.ArticleDatafetcherswitched fromgraphql.relay.DefaultPageInfoto the DGS codegen-generatedio.spring.graphql.types.PageInfo. Verify GraphQL cursor pagination queries return the correct shape.Stream.toList()immutability: SeveralCollectors.toList()calls were replaced withStream.toList(), which returns an unmodifiable list. Verify no downstream code mutates these lists (would throwUnsupportedOperationExceptionat runtime, not compile time).Recommended test plan: Start the app locally and exercise the REST API (registration, login, create/list/favorite articles, comments, user feed, tag filtering) and GraphQL API (same operations + cursor pagination). Pay close attention to date/time field serialization format in responses.
Notes
gradle-wrapper.properties); you may want to run./gradlew wrapper --gradle-version 8.7to regenerate it.Util.javawas deleted; its only method (isEmpty) was trivial and replaced inline.Link to Devin session: https://app.devin.ai/sessions/a3de8be7daa8433aba49fe127adbfe8f
Requested by: @stephencornwell