chore(AD-5): upgrade Spring Boot to 3.3.7 to fix CVE-2024-56337#569
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
chore(AD-5): upgrade Spring Boot to 3.3.7 to fix CVE-2024-56337#569devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
- Upgrade Spring Boot 2.6.3 -> 3.3.7 (brings patched tomcat-embed-core 10.1.x) - Upgrade Gradle wrapper 7.4 -> 8.10.2 - Migrate javax.* to jakarta.* (Servlet, Validation) - Rewrite WebSecurityConfig for Spring Security 6 (SecurityFilterChain) - Update JJWT API for 0.12.6 compatibility - Update DGS GraphQL to 9.1.3 (Spring GraphQL starter) - Update GraphQL exception handler for async API - Convert PageInfo from graphql-relay to generated types - Update all dependency versions for Boot 3.x compatibility - Java 11 -> 17 source/target compatibility Co-Authored-By: unknown <>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades Spring Boot from 2.6.3 to 3.3.7 to remediate CVE-2024-56337 (TOCTOU race condition in Apache Tomcat
tomcat-embed-core). Spring Boot 3.3.7 pulls intomcat-embed-core10.1.x which contains the fix.This is a major version upgrade (Boot 2 → 3) requiring the following cascading changes:
javax.*→jakarta.*namespace migration across all servlet/validation imports (~20 files)WebSecurityConfigurerAdapterwithSecurityFilterChainbean;antMatchers→requestMatchers;authorizeRequests→authorizeHttpRequestssubject(),expiration(),parser().verifyWith(),parseSignedClaims(),getPayload())graphql-dgs-spring-graphql-starter; exception handler now returnsCompletableFuture<DataFetcherExceptionHandlerResult>;PageInfoswitched fromgraphql.relay.DefaultPageInfoto generated typesCustomizeExceptionHandler:HttpStatus→HttpStatusCodein method signature (Boot 3 API change)All 68 existing tests pass locally.
Review & Testing Checklist for Human
SignatureAlgorithm.HS512withSecretKeySpec. The new code usesKeys.hmacShaKeyFor(secret.getBytes())which infers the algorithm from key byte length (≥64 → HS512, ≥48 → HS384, ≥32 → HS256). The configured secret inapplication.propertiesis 60 bytes → HS384, not HS512. This means any existing JWTs signed with the old code will fail to verify. Verify this is acceptable or adjust the secret to be ≥64 bytes.WebSecurityConfigrewrite preserves the same authorization rules — particularly thatGET /articles/feedstill requires auth, andPOST /users,POST /users/loginremain public.graphql-dgs-spring-boot-startertographql-dgs-spring-graphql-starter. Verify GraphQL endpoints (/graphql,/graphiql) still work correctly at runtime.Notes
gradle.yml) was intentionally removed per PR Remove GitHub Actions CI workflow #411, so there is no automated CI to validate this PR.javax.cryptoimports inDefaultJwtServicewere not migrated — this is correct asjavax.cryptois part of the JDK, not Jakarta EE.Link to Devin session: https://app.devin.ai/sessions/57df25bdaca94dc385a0572632d2bff9