Replace dids with dids_topo in gen_topo.f90
#51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Ed! I think it was conincidence it works for GEBCO. It might be because the first variables in GEBCO are lon & lat and the first variables in the output are lon & lat, but the order is different in the dataset you were trying (DTU_DKL_6_Ker50_pre_processed) |
anton-seaice
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As identified by @anton-seaice in this forum post.
Somehow the script worked anyway for GEBCO data. It only failed when I pointed it at a different bathymetry product. Implementing this change meant that the script has worked for the other datasets I've tried.
I've run the script twice (with and without the bug fix) using GEBCO as the input and compared the outputs. I get different MD5 hashes for the outputs (presumably because of the attributes holding info about the processing history?), but checked using
xarray.DataArray.equals("True if two DataArrays have the same dimensions, coordinates and values; otherwise False.") and thetopography.ncfiles are the same.