Fix incorrect indexing for MOM grid u-cells #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@anton-seaice, probably worth holding off review until I've fixed up the tests |
Collaborator
Author
|
Okay, ready for review @anton-seaice |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
+ Coverage 22.50% 23.16% +0.66%
==========================================
Files 20 20
Lines 1244 1256 +12
==========================================
+ Hits 280 291 +11
- Misses 964 965 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anton-seaice
approved these changes
Jun 18, 2025
Contributor
anton-seaice
left a comment
anton-seaice
left a comment
There was a problem hiding this comment.
Code review only - all looks correct
Co-authored-by: anton-seaice <anton.steketee@anu.edu.au>
test_cice_grid: Modify tests to allow lat/lon bounds Co-authored-by: anton-seaice <anton.steketee@anu.edu.au>
dougiesquire
force-pushed
the
mom-corners
branch
from
6dc54c1 to
fff1200
Compare
Collaborator
Author
|
Thanks @anton-seaice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes errors in the calculation of u-grid widths, areas and corner locations. I've also added
u[t]lat[lon]_boundsvariables to the CICE gridwritemethod if they are available.Closes #24