C4 Model: Fix entity names and filename for C4 modelling of Knowledge and Information Layer Server Containers#78
Merged
slawr merged 2 commits intoCOVESA:mainfrom Jul 22, 2025
Merged
Conversation
The current diagrams labelled the Knowledge Layer and Information Layer elements as a WIP as they had not yet been merged. Now they have been merged remove that text from the diagrams. Signed-off-by: Stephen Lawrence <stephen.lawrence@renesas.com>
* Correct the component diagram filename to show it is for the Knowledge and Information Layer containers. * Correct the diagram labels to show the KL and IL parts are C4 model containers and the parts within components. Signed-off-by: Stephen Lawrence <stephen.lawrence@renesas.com>
Collaborator
Author
|
Giving Christian and Haonan chance to comment before merging. |
chrizmc
approved these changes
Jul 22, 2025
Collaborator
chrizmc
left a comment
chrizmc
left a comment
There was a problem hiding this comment.
looks good, no additional comments from my side
Collaborator
Author
Thanks for the review. I think its straight forward but wanted to give you both a chance to review. I'll merge. |
github-project-automation
bot
moved this from In Progress
to Done
in Central Data Service Playground
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following merge of the Knowledge (KL) and Information Layer (IL) Server components apply some related fixes to the C4 Model of the CDSP architecture:
@claireqiu, @chrizmc if you can review the changes please. It's possible that some additional adjustments are still needed but they can be addressed in further PRs