[2주차] 객체지향 코드 연습(abeansu)#52
Open
abeansu wants to merge 35 commits intoCOW-edu:mainfrom
Open
Conversation
abeansu
requested review from
Hoya324,
KoSeonJe,
Seooooo24,
baaamk and
tiemo0708
as code owners
JongHyeok03
requested review from
JongHyeok03 and
yunjin1213
and removed request for
Hoya324,
KoSeonJe,
Seooooo24,
baaamk and
tiemo0708
hughryu1125
reviewed
Apr 2, 2026
hughryu1125
left a comment
hughryu1125
left a comment
There was a problem hiding this comment.
수고하셨습니다!
새로 commit을 하셔서 리뷰는 지금 끊었다가 다시 하도록 하겠습니다
Comment on lines
+69
to
+75
| private List<Integer> pickRandomNumbers() { | ||
| return Randoms.pickUniqueNumbersInRange( | ||
| Constants.MIN_LOTTO_NUMBER, | ||
| Constants.MAX_LOTTO_NUMBER, | ||
| Constants.LOTTO_NUMBER_COUNT | ||
| ); | ||
| } |
There was a problem hiding this comment.
이 부분도 마찬가지로 MVC 패턴에서 로직은 model이 가지고 있는 것이 적절해 보여요!
# Conflicts: # src/main/java/kr/abins/lotto/Application.java # src/main/java/kr/abins/lotto/controller/LottoGenerator.java # src/main/java/kr/abins/lotto/controller/LottoProcessor.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.