Sync dev branch with Latest v4.4#218
Merged
JeanCarlosChavarriaHughes merged 39 commits intodevfrom Oct 3, 2025
Merged
Conversation
Sync branch v4.4 with the latest working version
quick v4.4 schema version update, policy hash update and other minor changes
Updated vendored composer autoloader to latest LTS This should keep autoloader compatible with PHP 5.5 yet phpmailer now supports PHP 8.4 so it is worth the bump
Add claimedRole Emisor and update phpmailer
* Fix of function typo definition * Adding files permission in Dockerfile * Improve legibility of comments Signed-off-by: JeanCarlos Chavarria <jeancarlos.chavarria19@gmail.com>
4.4: Update signature policy URL
* Fix of function typo definition * Adding files permission in Dockerfile * Improve legibility of comments * Improve comments of dockerfile * Update year to 2025 Signed-off-by: JeanCarlos Chavarria <jeancarlos.chavarria19@gmail.com>
* Issue#125 adding ProveedorSistemas to genXML --------- Signed-off-by: JeanCarlos Chavarria <jeancarlos.chavarria19@gmail.com> Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com>
Add Resumen Comprobante changes of v4.4 Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com>
Missing parentesis parse error
* Update informacion de referencia node - Fix issue #140 - Fix issue #141 - Fix issue #172 - Apply PHP Code Style Rules to genXML.php and module.php - Reduce extra spaces - Force brackets to if condition statements to facilitate maintenance. - Update json sample for FEE in InformacionReferencia * Update Otros nodo and comments issue#108 * Resolve #180 update XSD files Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com>
* Fix Issue#137 * Fix wrong variable accessing issue#137 --------- Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com>
* Fix Issue#137 Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix wrong variable accessing issue#137 Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix Issue#136 Issue#174 Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix issue#128 Adding NumeroVINoSerie Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix issue#131 Add TipoTransaccion Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix issue #131 - Update Codigo to CodigoCabys - Remove CodigoComercialLinea duplicated field. Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix issue in codigoComercial logic Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix Issue#132 Update Descuento Nodo in genXML Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix #135 Adding DatosImpuestoEspecifico, CodigoImpuestoOTRO Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix #134 Adding FactorCalculoIVA, CodigoTarifaIVA Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix #129 Adding DetalleSurtido complex node Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix #178 Adding FormaFarmaceutica, RegistroMedicamento Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Adding basic phpUnit test cases for genXML-FE Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Issue #68 adding phpunit workflow Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix #68 Fix issues with genXML Added test cases: - testGenXMLFeBasic - testGenXMLFeInformacionReferencia - testGenXMLFeOtros - testGenXMLFeMedioPago Pending to complete: - testGenXMLFeFullStructure Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix #68 implement basic PHPUnit for genXML FE Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> --------- Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com>
* Harden type comparison * Drop fallback avatar feature, provide empty image instead. * Create a convenience permissions function to disable access to anyone and apply by default to sensitive functions * Reduce duplicate calculated values
* first changes and setup * incluir www/settings.php * typo en instrucciones, remover branch del workflow * Agregar validaciones de campos requeridos en FE * fix: formato y validaciones en modulo 'clave' * fix: typo en valor devuelto
…_repetido Se elimino el parametro duplicado total_impuestos Fixes #213
Signed-off-by: JeanCarlos Chavarria <jeancarlos.chavarria19@gmail.com>
…209/update-composer-lock Update composer.lock Fix Issue #209
Signed-off-by: JeanC Ch. H. <jeancarlos.chavarria19@gmail.com>
Collaborator
Author
|
@fdelapena PR conflicts are addressed. |
ghost
approved these changes
Oct 3, 2025
JeanCarlosChavarriaHughes
added a commit
that referenced
this pull request
Oct 6, 2025
* Docker files updated (#189) * [update] docker configuration updated to persist data across restart of containers * [update] readme.md and docker-compose.md updated with only new docker info * Sync dev branch with Latest v4.4 (#218) * Check php version and extensions from Composer * Allow pfx uploading for some sello electrónico use cases * Update policy URI PDF File hash and path, initial base schema URI changes * Schema version quick update * Update vendored phpmailer from 6.5.0 to 6.9.3 Updated vendored composer autoloader to latest LTS This should keep autoloader compatible with PHP 5.5 yet phpmailer now supports PHP 8.4 so it is worth the bump * Add xades:ClaimedRole Emisor. Fixes #143 * Backport default PHP 8.1+ mysqli error reporting * Backport default PHP 8.1+ mysqli error reporting * Escape SQL queries, fixes #121 * V4.4 (#182) * Bugfix/function typo docker files permission (#183) * Fix of function typo definition * Adding files permission in Dockerfile * Improve legibility of comments Signed-off-by: JeanCarlos Chavarria <jeancarlos.chavarria19@gmail.com> * 4.4: Update signature policy URL * Update year to 2025 (#184) * Fix of function typo definition * Adding files permission in Dockerfile * Improve legibility of comments * Improve comments of dockerfile * Update year to 2025 Signed-off-by: JeanCarlos Chavarria <jeancarlos.chavarria19@gmail.com> * Issue 125 adding proveedor sistemas (#188) * Issue#125 adding ProveedorSistemas to genXML --------- Signed-off-by: JeanCarlos Chavarria <jeancarlos.chavarria19@gmail.com> Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Add Encabezado changes of v4.4 (#190) Encabezado changes of v.4.4 are added. Resolved #125 Resolved #124 Resolved #104 Resolved #103 Resolved #101 --------- Signed-off-by: JeanCarlos Chavarria <jeancarlos.chavarria19@gmail.com> Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Add Resumen Comprobante changes of v4.4 (#192) Add Resumen Comprobante changes of v4.4 Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Update facturadorCRLibre.php (#193) Missing parentesis parse error * Update Otros, Informacion Referencia, and XSD to meet v4.4 (#195) * Update informacion de referencia node - Fix issue #140 - Fix issue #141 - Fix issue #172 - Apply PHP Code Style Rules to genXML.php and module.php - Reduce extra spaces - Force brackets to if condition statements to facilitate maintenance. - Update json sample for FEE in InformacionReferencia * Update Otros nodo and comments issue#108 * Resolve #180 update XSD files Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * V4.4 - Resolve issue #133 (#196) * Issue-133 add IVACobradoFabrica to detalles * Issue#133 fix wrong accessor Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix Issue#137 (#197) * Fix Issue#137 * Fix wrong variable accessing issue#137 --------- Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Complete v4.4 implementation of missing fields (#198) * Fix Issue#137 Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix wrong variable accessing issue#137 Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix Issue#136 Issue#174 Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix issue#128 Adding NumeroVINoSerie Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix issue#131 Add TipoTransaccion Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix issue #131 - Update Codigo to CodigoCabys - Remove CodigoComercialLinea duplicated field. Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix issue in codigoComercial logic Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix Issue#132 Update Descuento Nodo in genXML Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix #135 Adding DatosImpuestoEspecifico, CodigoImpuestoOTRO Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix #134 Adding FactorCalculoIVA, CodigoTarifaIVA Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix #129 Adding DetalleSurtido complex node Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix #178 Adding FormaFarmaceutica, RegistroMedicamento Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Adding basic phpUnit test cases for genXML-FE Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Issue #68 adding phpunit workflow Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix #68 Fix issues with genXML Added test cases: - testGenXMLFeBasic - testGenXMLFeInformacionReferencia - testGenXMLFeOtros - testGenXMLFeMedioPago Pending to complete: - testGenXMLFeFullStructure Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Fix #68 implement basic PHPUnit for genXML FE Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> --------- Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Update README.md * Address SAST report issues (#201) * Harden type comparison * Drop fallback avatar feature, provide empty image instead. * Create a convenience permissions function to disable access to anyone and apply by default to sensitive functions * Reduce duplicate calculated values * Docker files updated (#189) (#203) * [update] docker configuration updated to persist data across restart of containers * [update] readme.md and docker-compose.md updated with only new docker info Co-authored-by: Onier Crestelo <80003063+onier9702@users.noreply.github.com> * Create ossar.yml * Delete .github/workflows/ossar.yml * Mejoras en configuración, formato de código y manejo de errores (#207) * first changes and setup * incluir www/settings.php * typo en instrucciones, remover branch del workflow * Agregar validaciones de campos requeridos en FE * fix: formato y validaciones en modulo 'clave' * fix: typo en valor devuelto * Fix Issue #210 #211 (#212) Fix Issue #210 #211 * Ajuste Medios de Pago para FEE en v4.4 * El campo informacion_referencia aparece como requerido en FE, pero no es requerido --------- Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> * Remove commented URL from codigoActividadEmisor * Remove redundant comments for codigo_actividad_emisor * eliminar duplicado de clave 'total_impuestos' en la función crlibreall_init * Update composer.lock Signed-off-by: JeanCarlos Chavarria <jeancarlos.chavarria19@gmail.com> --------- Signed-off-by: JeanCarlos Chavarria <jeancarlos.chavarria19@gmail.com> Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> Signed-off-by: JeanC Ch. H. <jeancarlos.chavarria19@gmail.com> Co-authored-by: Francisco de la Peña <fran@fran.cr> Co-authored-by: Randall Mora <50120822+randallmoraes@users.noreply.github.com> Co-authored-by: Onier Crestelo <80003063+onier9702@users.noreply.github.com> Co-authored-by: David Obando <david@itros.net> Co-authored-by: Jose Mota <motajose14@gmail.com> --------- Signed-off-by: JeanCarlos Chavarria <jeancarlos.chavarria19@gmail.com> Signed-off-by: Jean Chavarria <jeancarlos.chavarria19@gmail.com> Signed-off-by: JeanC Ch. H. <jeancarlos.chavarria19@gmail.com> Co-authored-by: Onier Crestelo <80003063+onier9702@users.noreply.github.com> Co-authored-by: Francisco de la Peña <fran@fran.cr> Co-authored-by: Randall Mora <50120822+randallmoraes@users.noreply.github.com> Co-authored-by: David Obando <david@itros.net> Co-authored-by: Jose Mota <motajose14@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.