Add a new firmador module that replaces the previous#219
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new firmador module that replaces the previous signing modules. The update involves removing several old XML signing modules and introducing a simplified, standalone XML signing implementation.
- Removes the deprecated
signXMLandfirmarXMLmodules with their dependencies - Introduces a new streamlined
firmadormodule with backward compatibility - Updates Postman collection and references to use the new module endpoints
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| recursos/API CRLibre.postman_collection V3.1.json | Updates Postman collection endpoints from signXML/signFE to firmador/firmar |
| api/tools/cli-signer.php | Removes deprecated CLI signer tool |
| api/contrib/signXML/ | Removes entire deprecated signXML module and dependencies |
| api/contrib/firmarXML/ | Removes entire deprecated firmarXML module and xmlseclibs dependency |
| api/contrib/firmador/ | Adds new simplified firmador module with backward compatibility functions |
| api/contrib/crlibreall/module.php | Updates comments to reference new firmador module |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
|
The new version is not fully backwards compatible as it requires the user to change Also, there are several warning in the console. |
Collaborator
added 5 commits
October 30, 2025 13:19
Author
|
Renamed to crearXML using same function name and file. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Additionally: