-
Notifications
You must be signed in to change notification settings - Fork 1
Add CI/CD pipeline for testing and Docker deployment #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a workflow for building and running two jobs based on project requirements in the rubric
There were some indentation errors in the yaml file, that caused the workflow in actions to fail.
testing update for deploy job in the .yaml
made devtest environment to hold AWS secrets for testing
changed wrong job to devtest environment. corrected
had error with docker not being installed on the aws server. got instructions on how to install docker on ubuntu from docker website and included in script changed 8000:8000 to 80:8000 to match online examples, will need reexamined included command to stop docker after successfully running the container because I don't understand AWS and am worried about racking up a bill, but this will have to be removed before the aws deployment is functional
I guess all docker commands must be sudo? Seems sketchy.
docker was not installing correctly, so trying this alternative and much simpler command using apt-get instead of apt
updated logic to stop and then remove all docker containers before pulling and running the updated image
changed cleanup logic to stop the running weather_planner_app container, remove the container, and then remove the old image before pulling the newest
added || True statements to the cleanup logic to avoid breaking the script if the container/images are not there
testing improvement in deployment with a seperate job to set up the server
went back to -p 8000:8000 rather than 80:8000
port 80
added one line to see if we can verify with github actions that at least one endpoint is functional
changed to port 80
creates a testdeploy job
Gh actions extra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a workflow for building and running two jobs based on project requirements in the rubric