Skip to content

[COMPLETED] Test added for MySQL template#111

Closed
GMHarish285 wants to merge 5 commits intoCSE-25:mainfrom
GMHarish285:qse_mysqltest
Closed

[COMPLETED] Test added for MySQL template#111
GMHarish285 wants to merge 5 commits intoCSE-25:mainfrom
GMHarish285:qse_mysqltest

Conversation

@GMHarish285
Copy link
Contributor

Solves #28

@GMHarish285
Copy link
Contributor Author

I did not use mock db because I thought using real db means we also check database connection and data retrieval. And anyways we are going to initialize the database as reInitDb is in index.js.

Copy link
Member

@Ashrockzzz2003 Ashrockzzz2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GMHarish285

This still depends on a local MySQL running. If you can make it work with GitHub Actions CI fine.

I was thinking, we can run the tests on a dockerized instance of this template using the compose script that's generated!

@Ashrockzzz2003
Copy link
Member

Much more refinements to go. Bounty for WOC now as it's closed.

@Ashrockzzz2003
Copy link
Member

/bounty 40 @GMHarish285

@Ashrockzzz2003
Copy link
Member

@GMHarish285
Closing the PR now, reopen it when you start working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants