Updating World#373
Open
langmaninternet wants to merge 1 commit intoCSTR-Edinburgh:masterfrom
langmaninternet:master
Open
Updating World#373langmaninternet wants to merge 1 commit intoCSTR-Edinburgh:masterfrom langmaninternet:master
langmaninternet wants to merge 1 commit intoCSTR-Edinburgh:masterfrom
langmaninternet:master
Conversation
+ Fix FFT functions ( ref mmorise/World@7a474fa) +Update random and add reseed the pseudo-random number generator each time extract f0, sp, ap (ref mmorise/World@9a26692 ) + Add sample rate parameter to function InitializeCheapTrickOption to same with new world version . (This allow this code compatible with some wrapper for world . Example : https://github.com/JeremyCCHsu/Python-Wrapper-for-World-Vocoder )
ZackHodari
reviewed
Mar 14, 2019
| g_randn_x = g_randn_y; | ||
| g_randn_y = g_randn_z; | ||
| g_randn_z = g_randn_w; | ||
| g_randn_w = (g_randn_w ^ (g_randn_w >> 19)) ^ (t ^ (t >> 8)); |
Contributor
There was a problem hiding this comment.
This does not match with mmorise's commit, is there a reason?
mmorise/World@9a26692#diff-187e775cb821482add4032722c5e716aR262
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
+Update random and add reseed the pseudo-random number generator each time extract f0, sp, ap (ref mmorise/World@9a26692 )
Example : https://github.com/JeremyCCHsu/Python-Wrapper-for-World-Vocoder )