BLSTM implementation in keras_lib#391
Open
cveaux wants to merge 3 commits intoCSTR-Edinburgh:masterfrom
Open
Conversation
Correct BLSTM implementation in keras_lib
Correct BLSTM implementation in keras_lib
Correct BSLTM implementation in keras_lib
ZackHodari
requested changes
Mar 14, 2019
Contributor
ZackHodari
left a comment
ZackHodari
left a comment
There was a problem hiding this comment.
Can you rebase into one commit and add a description to the new commit please
| return_sequences=True, | ||
| go_backwards=True)) | ||
| return_sequences=True), | ||
| input_shape=(None, input_size), |
Contributor
There was a problem hiding this comment.
Can you fix indentation please
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
it seems that the current blstm implementation in keras_lib is just a backwards lstm and not a bidirectional lstm. This pull request fixes this, using the
Bidirectionalkeras wrapper (https://keras.io/layers/wrappers/)p.s: The code has been tested for the sequence model but not the stateful model.