Iterative thresholds + DP correction#92
Open
tostafin wants to merge 22 commits intoCTPPS:rolling-calib-timing-calibration-14_1_4from
Open
Iterative thresholds + DP correction#92tostafin wants to merge 22 commits intoCTPPS:rolling-calib-timing-calibration-14_1_4from
tostafin wants to merge 22 commits intoCTPPS:rolling-calib-timing-calibration-14_1_4from
Conversation
Co-authored-by: Tomasz Ostafin <tomasz.dariusz.ostafin@cern.ch>
…with cms-merge-topic
The thresholdFractionOfMax parameter is removed and replaced by iterative thresholds plus fixed bounds to find the best fit based on chi^2 and ndf.
Adding implementation for correcting double peaks which sometimes occur in the leading edge histograms. The algorithm finds the LS at which the double peak happens, computes the required time offset and passes this information to the worker to correct t and t vs TOT histograms, as well as to the harvester to save it into the SQLite file.
fbe83a9 to
063c2fd
Compare
946fe02 to
0813d12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.