Fix homepage hero/header gap with homepage-only selector#124
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
body[data-md-page="index"]/.md-home), so the fixes never applied.Description
body:has(.oasis-hero)and update all homepage-specific rules to use it indocs/styles/extra.css..md-content__innerand.md-main__inner(setpadding-top: 0 !important; margin-top: 0 !important;)..oasis-hero { margin-top: calc(var(--md-header-height) * -1); padding-top: var(--md-header-height); }) so hero content does not slide under the header.docs/styles/extra.css(replacedbody[data-md-page="index"]/.md-homeblocks withbody:has(.oasis-hero)rules and removed the old homepage selectors).body:has(.oasis-hero), and the element causing the gap was.md-content__inner(site base CSS also applies.md-main__inner { margin-top: 1.5rem; }).Testing
mkdocs build -q --site-dir /tmp/sitebuildto produce a built site and confirmed the build completed successfully.<body dir="ltr" data-md-color-scheme="default" data-md-color-primary="custom" data-md-color-accent="custom">and confirmed that the homepage hero markup is<div class="esiil-banner oasis-hero">sobody:has(.oasis-hero)will match the homepage.chromiumruns were unstable in this environment, while WebKit runs produced page screenshots, but environment limitations prevented a single guaranteed DOM snapshot workflow; CSS changes were still validated via the built output and local stylesheet diff.mkdocs buildsucceeded and the CSS tweaks were applied indocs/styles/extra.css(homepage-only rules now targetbody:has(.oasis-hero)and the top gap rules were reset).Codex Task