Fix homepage hero/sidebar overlap in desktop layout#125
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
.oasis-layout > .oasis-maincontainer indocs/index.mdso the hero sits within the main content column.--oasis-sidebar-wand authoritative desktop two-column flex layout indocs/styles/extra.css, definingdisplay:flexon.oasis-layoutand sizing for.oasis-sidebarand.oasis-main..oasis-main .oasis-heroand removed the earlierwidth:100vwand negative margins, replacing them withwidth:100%and zeroed margins so the hero no longer forces a full-bleed layout..oasis-main .oasis-hero::beforerules at desktop sizes so the hero background/pseudo-element starts at the main column left edge and does not extend under the sidebar.Testing
mkdocs buildsuccessfully to ensure the site builds with the CSS and markup changes.mkdocs serve) and captured a desktop screenshot via Playwright to visually confirm the hero background and text no longer sit beneath the left tags sidebar.docs/index.mdanddocs/styles/extra.cssto confirm the expected markup moves and CSS updates were applied.Codex Task