Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
:has()selectors and scope homepage-only styles to a controlled structure so rules cannot leak to other pages.Description
body:has(...)homepage selectors indocs/styles/extra.csswith structure-rooted selectors using.oasis-layoutand.oasis-main(content padding, H1 spacing, hero spacing, and kicker styling now scoped to.oasis-layout)..oasis-layout .oasis-main .oasis-herousingmargin-top: calc(var(--md-header-height, 3rem) * -1)andpadding-top: var(--md-header-height, 3rem).--oasis-sidebar-w: 300pxand hardened desktop sidebar sizing withoverflow: hiddenand added.oasis-sidebar * { max-width: 100%; }to prevent children from forcing expansion..oasis-mainand did not reintroduce any100vwor negative viewport-offset tricks.Testing
rg ':has\(' docs/styles/extra.cssand confirmed there are no:has()selectors remaining in the file.mkdocs buildsuccessfully (build completes; existing documentation link warnings are pre-existing and unrelated).mkdocs serve+ Playwright screenshot) to verify the hero touches the header, is not under the sidebar, and the sidebar width is stable; visual check succeeded.Codex Task