Skip to content

Conversation

@joshuanapoli
Copy link
Member

  • Clarify that this SDK uses the MIT license.
  • Upgrade to python-claude@0.3.0

@linear
Copy link

linear bot commented Dec 8, 2025

PD1-323 Standardize Python repos to use mypy and ruff

Standardize on Python 14. TensorFlow projects may need to use Python 13, instead.

Ruff replaces several linters and formatters:

  • black
  • flake8
  • trailing-whitespace
  • end-of-file-fixer
  • isort

Change:

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @joshuanapoli, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the project's metadata by explicitly declaring the MIT license, ensuring clarity regarding its usage terms. Concurrently, it updates a core development dependency, python-claude, to its latest version, bringing in potential new features or bug fixes. The changes also include a refinement of the development workflow by adjusting when code quality checks like ruff format and mypy are executed.

Highlights

  • License Declaration: Explicitly declared the SDK's license as MIT in pyproject.toml to clarify its open-source terms.
  • Dependency Upgrade: Upgraded the python-claude development dependency from version 0.1.1 to 0.3.0.
  • Development Hooks Reconfiguration: Reconfigured the .claude/settings.json hooks to execute ruff format and mypy during the 'Stop' phase instead of 'Write|Edit', streamlining the development workflow.
  • Project Version Bump: Incremented the project version in pyproject.toml from 1.4.0 to 1.4.1.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds MIT license metadata to the pyproject.toml file, upgrades the python-claude development dependency, and refactors the .claude/settings.json hooks. The changes are generally good, but I have a couple of suggestions for improvement. I've recommended adding the --strict flag to the mypy command in .claude/settings.json for consistency with your lint.sh script. I've also suggested adding a license classifier to pyproject.toml to provide richer metadata for packaging tools.

Copy link

@olivierpichon olivierpichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💯

@joshuanapoli joshuanapoli merged commit fd32a5a into main Dec 8, 2025
11 checks passed
@joshuanapoli joshuanapoli deleted the jn/python-claude branch December 8, 2025 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants