-
Notifications
You must be signed in to change notification settings - Fork 0
[PD1-323] Add license metadata #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
joshuanapoli
commented
Dec 8, 2025
- Clarify that this SDK uses the MIT license.
- Upgrade to python-claude@0.3.0
PD1-323 Standardize Python repos to use mypy and ruff
Standardize on Python 14. TensorFlow projects may need to use Python 13, instead. Ruff replaces several linters and formatters:
Change: |
Summary of ChangesHello @joshuanapoli, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on enhancing the project's metadata by explicitly declaring the MIT license, ensuring clarity regarding its usage terms. Concurrently, it updates a core development dependency, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds MIT license metadata to the pyproject.toml file, upgrades the python-claude development dependency, and refactors the .claude/settings.json hooks. The changes are generally good, but I have a couple of suggestions for improvement. I've recommended adding the --strict flag to the mypy command in .claude/settings.json for consistency with your lint.sh script. I've also suggested adding a license classifier to pyproject.toml to provide richer metadata for packaging tools.
olivierpichon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 💯