Skip to content

[PD1-323] Add license-files metadata for PyPI #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshuanapoli merged 2 commits into from
Dec 8, 2025
Merged

[PD1-323] Add license-files metadata for PyPI #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0649adf
chore: add license-files
joshuanapoli Dec 8, 2025
ffb328a
chore: add classifiers
joshuanapoli Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "cvec"
version = "1.4.1"
version = "1.4.3"
description = "SDK for CVector Energy"
authors = [{ name = "CVector", email = "support@cvector.energy" }]
readme = "README.md"
Expand All @@ -10,6 +10,18 @@ dependencies = [
"pyarrow>=22.0.0",
]
license = "MIT"
license-files = ['LICENSE']
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While this line correctly adds the license file to the package metadata, I've noticed a larger structural issue in this file. The project is configured to use Poetry as its build backend, but the dependencies are declared under the [project] table.

Poetry's dependency management tools (e.g., poetry install, poetry add) do not use the [project.dependencies] field. They expect dependencies to be defined in [tool.poetry.dependencies]. This discrepancy can lead to an inconsistent or broken development environment, as developers using Poetry commands won't have the correct dependencies installed.

To ensure project maintainability and a consistent developer experience, I strongly recommend moving the dependencies to the [tool.poetry] section in a follow-up change. You would remove the dependencies and requires-python keys from [project] and create a [tool.poetry.dependencies] section like this:

[tool.poetry.dependencies]
python = ">=3.10"
pydantic = ">=2.12.0"
pyarrow = ">=22.0.0"

classifiers = [
"License :: OSI Approved :: MIT License",
"Operating System :: OS Independent",
"Programming Language :: Python :: 3",
'Intended Audience :: Developers',
'Programming Language :: Python :: 3.10',
'Programming Language :: Python :: 3.11',
'Programming Language :: Python :: 3.12',
'Programming Language :: Python :: 3.13',
'Programming Language :: Python :: 3.14',
]

[tool.poetry]
packages = [{ include = "cvec", from = "src" }]
Expand Down