-
Notifications
You must be signed in to change notification settings - Fork 0
Implement global CactusBot packet specification #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
2Cubed
wants to merge
2
commits into
master
Choose a base branch
from
fix/packet-format
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,67 @@ | ||
| package schemas | ||
|
|
||
| // MessagePacket is the low-level format for storing contents of a message and arguments | ||
| type MessagePacket struct { | ||
| Data string `json:"data" validate:"required"` | ||
| Text string `json:"text" validate:"required"` | ||
| Type string `json:"type" validate:"required"` | ||
| import ( | ||
| "strings" | ||
| ) | ||
|
|
||
| // TODO: Remove `jsonapi:` tags. Should just be `json:`. | ||
| type Message struct { | ||
| Text []Component `jsonapi:"attr,text"` | ||
| Action bool `jsonapi:"attr,action"` | ||
| } | ||
|
|
||
| // TODO: Remove `jsonapi:` tags. Should just be `json:`. | ||
| type Component struct { | ||
| Type string `jsonapi:"attr,type"` // HACK: need to validate type | ||
| Data string `jsonapi:"attr,data"` | ||
| } | ||
|
|
||
| type Channel string | ||
| type User string | ||
| type Service string | ||
|
|
||
| // TODO: Remove `jsonapi:` tags. Should just be `json:`. | ||
| type Context struct { | ||
| Packet Message `jsonapi:"attr,packet"` | ||
| Channel Channel `jsonapi:"attr,channel"` | ||
| User User `jsonapi:"attr,user,omitempty"` | ||
| Role Role `jsonapi:"attr,role,omitempty"` // FIXME: should return string ("owner"), not int (5). See UnmarshalJSON below. | ||
| Target User `jsonapi:"attr,target,omitempty"` | ||
| Service Service `jsonapi:"attr,service"` | ||
| } | ||
|
|
||
| type Role int | ||
|
|
||
| const ( | ||
| banned Role = iota | ||
| user | ||
| subscriber | ||
| moderator | ||
| owner | ||
| ) | ||
|
|
||
| func (r *Role) UnmarshalJSON(b []byte) error { | ||
| str := strings.Trim(string(b), `"`) | ||
|
|
||
| switch { | ||
| case str == "banned": | ||
| *r = banned | ||
|
|
||
| case str == "user": | ||
| *r = user | ||
|
|
||
| case str == "subscriber": | ||
| *r = subscriber | ||
|
|
||
| case str == "moderator": | ||
| *r = moderator | ||
|
|
||
| case str == "owner": | ||
| *r = owner | ||
|
|
||
| default: | ||
| *r = user | ||
| } | ||
|
|
||
| return nil | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,21 +55,21 @@ func pullVals(ift reflect.Type, ifv reflect.Value) (map[string]interface{}, map[ | |
| id = subID | ||
| } | ||
| } | ||
| // Anything after the first element is tags, figure out which we want | ||
| for _, tag := range split[1:] { | ||
| // Need to set the keys w/ their names here if it's a struct | ||
| switch tag { | ||
| case "attr": | ||
| // Attribute | ||
| attr[split[0]] = value | ||
| case "meta": | ||
| // Meta information about the request | ||
| meta[split[0]] = value | ||
| case "primary": | ||
| // It's the primary key/record ID | ||
| id = ifv.Field(i).String() | ||
| default: // Ignore any other tags | ||
| } | ||
| // Need to set the keys w/ their names here if it's a struct | ||
| switch split[0] { | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @RPiAwesomeness Will this change have any negative side effects? |
||
| case "attr": | ||
| // Attribute | ||
| attr[split[1]] = value | ||
| break | ||
| case "meta": | ||
| // Meta information about the request | ||
| meta[split[1]] = value | ||
| break | ||
| case "primary": | ||
| // It's the primary key/record ID | ||
| id = ifv.Field(i).String() | ||
| break | ||
| default: // Ignore any other tags | ||
| } | ||
| } | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of these fields seem to be automatically populated. (Instead, it looks like they're just "made up" later on.) I'm assuming this is still WIP?