Create Plane from Location #1912
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise creating of Plane from tuple of int does not work anymore due to introduced @multimethod
Instead of just creating a temporary plane and rotating it
multimethod did not work, as that disallows keyword arguments for construction of Plane, which ruins many tests multidispatch works with keyword arguments, but looks horrible in docs Construction from class method just works.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1912 +/- ##
=======================================
Coverage 95.74% 95.75%
=======================================
Files 29 29
Lines 7827 7842 +15
Branches 1179 1179
=======================================
+ Hits 7494 7509 +15
Misses 192 192
Partials 141 141 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| self.origin = Vector(origin) | ||
|
|
||
| @classmethod | ||
| def fromLocation(cls, loc: "Location",) -> "Plane": |
There was a problem hiding this comment.
Why not an __init__ overload?
There was a problem hiding this comment.
Ah I see it in the description. I think we'd rather have an __init__ version.
Sphinx fix PRs are highly welcome ;). Probably it will require a custom plugin...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all: I love working with CQ, thank you for maintaining this library!
Plane supports conversion between local/global coordinate systems, and Location supports chaining coordinate-system offsets.
So I from time to time want to convert between them.
However, while there is a
Location.__init__fromPlaneand aLocation.planeproperty, I did not find an implementation of the opposite conversion.This PR adds this conversion from
LocationtoPlane.Some things I ask the reviewers to notice and possibly discuss:
@multimethodonPlane.__init__. But that then disallows passing keyword arguments to the constructor, and that is needed in existing code. Using@multidispatchproduces working code, but Sphinx docs do not support it. So I leftPlane.__init__untouched and added aPlane.fromLocationclass-method.Location.planeproperty I added is analogous toPlane.location.Planeand then runs through a chain of conversions Plane -> Location -> Plane -> Location. In the end, there are two Planes and two Locations, which have to be equal, respectively. This is asserted, along with origin and rotations of the first created Location.I'm excited about your feedback!