Change prefix

[Shelob9]

To fix issue #5 in Ingot I switched to a fork that changes "caldera" to "calmodal" in JS/CSS. Sensible fix, but I worry beacuse we used these modals in Postmatic and called them programmatically that if we merge this, it will break the optins in Postmatic, so let's discuss this with @cyberhobo before merge

[cyberhobo]

Thanks. I don't see 'caldera' in any of Postmatic's CSS, and only $('<div>').calderaModal() calls in our JS. That shouldn't change right?

Still, if you're not in a hurry I'd feel better if I could check out this branch and do a few tests with it.

[Shelob9]

@cyberhobo That line is 100% going to break Postmatic. There is no longer a function called calderaModal if we make this change. It will be calmodalModal

I had to change the CSS and JS prefixes beacuse Ingot's use of Caldera Modals and Caldera Forms' almost identical modal system were clashing, which was embarassing...

[cyberhobo]

@Shelob9 how about you tag the current master with a version we can depend on in Postmatic for now? Then you could submit a Postmatic PR that works with the new version 😁

[Shelob9]

@cyberhobo Use tag 1.0.1 https://github.com/CalderaWP/caldera-modals/releases/tag/1.0.1

Once @Desertsnowman merges this I'll tag it as 1.1.0 and then PR postmatic.

[cyberhobo]

Will do, thanks @Shelob9.

On Thu, Jun 2, 2016 at 3:52 PM, Josh Pollock notifications@github.com
wrote:

@cyberhobo https://github.com/cyberhobo Use tag 1.0.1
https://github.com/CalderaWP/caldera-modals/releases/tag/1.0.1

Once @Desertsnowman https://github.com/Desertsnowman merges this I'll
tag it as 1.1.0 and then PR postmatic.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#6 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AARgdvRsYTrAcGt4QKaMkncrNsStGQ-oks5qH17JgaJpZM4IsH6z
.

[cyberhobo]

For reference Postmatic 2.0.4 will include caldera-modals 1.0.1: postmatic/postmatic-basic@005e134