refactor: add /trasaction/nonce and /transaction/submit endpoints #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiooshiro
force-pushed
the
feature/eip712-transaction-endpoint
branch
from
31658d0 to
8cf8563
Compare
sandhilt
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (1)
- internal/paio/oapi-paio.yaml: Language not supported
Comments suppressed due to low confidence (2)
internal/paio/generated.go:477
- [nitpick] The renaming from SaveTransactionRequest to NewGetNonceRequest might be confusing to developers familiar with the legacy naming. Consider updating the function documentation to clearly state this is part of the new /transaction/nonce endpoint implementation.
// NewGetNonceRequest calls the generic GetNonce builder with application/json body
internal/paio/paio.go:972
- [nitpick] The route definitions now include both deprecated endpoints (e.g. '/nonce', '/submit') and their new counterparts (e.g. '/transaction/nonce', '/transaction/submit'), which could lead to confusion. It is recommended to add clearer documentation or comments to distinguish their intended uses.
router.POST(baseURL+"/nonce", wrapper.GetNonceDeprecated)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.