fix(vault): validate on-ledger token balance during init#217
Merged
greatest0fallt1me merged 3 commits intoCalloraOrg:mainfrom Mar 31, 2026
Merged
Conversation
|
@iammrjude Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Closes #153
This PR updates
callora-vaultsoinitnow validates the vault's on-ledger USDC balance before accepting a positiveinitial_balance.What changed
contracts/vault/src/lib.rsinitnow fails fast with:initial_balance exceeds on-ledger USDC balanceinitial_balancevalues trigger the token-balance readinitial_balanceinitial_balanceexceeds the actual token balanceinitial_balancewithout pre-funding the vaultINVARIANTS.mdso the documentedinitpreconditions match the implementationWhy
INVARIANTS.mdalready states that when a vault is initialized with an internal starting balance, the contract should already hold at least that much USDC on-ledger. This PR makes that invariant explicit in code.Validation
Ran locally from the workspace root:
cargo fmt --allcargo fmt --all --checkcargo clippy --all-targets --all-features -- -D warningscargo testcargo build --target wasm32-unknown-unknown --release -p callora-vaultstellar contract build --package callora-vaultcargo tarpaulin --config tarpaulin.tomlTest summary
596/602)Security notes
Reviewer note
This branch is currently stacked on top of the CI fixes from
#138so that the full validation suite stays green before that PR merges. Once#138is merged, this PR can be retargeted tomainand the diff should reduce to the#153vault/invariant changes.