refactor(airc-bash): final cmd_X sweep — Phase 3 file split COMPLETE

[joelteply]

Summary

The final structural sweep — pulls the last three cmd_X groups out of the airc top-level:

• `cmd_reminder` → `lib/airc_bash/cmd_reminder.sh`
• `cmd_rename` → `lib/airc_bash/cmd_rename.sh`
• `cmd_update + cmd_channel + cmd_version` → `lib/airc_bash/cmd_update.sh`

```
airc top-level: 1898 → 1663 lines (-235)
```

Phase 3 file split — END STATE

	Before #213	Now
airc top-level	5265	1663 (-68%)
lib/airc_bash/	0	4569 across 13 files

```
lib/airc_bash/cmd_connect.sh 1379 (join/pair/host orchestrator)
lib/airc_bash/cmd_daemon.sh 461 (autostart family + helpers)
lib/airc_bash/cmd_rooms.sh 441 (channel/peer cluster)
lib/airc_bash/cmd_doctor.sh 441 (env health + connect preflight)
lib/airc_bash/cmd_identity.sh 448 (presence: away/identity/whois)
lib/airc_bash/cmd_send.sh 383 (outbound: send + ping)
lib/airc_bash/cmd_teardown.sh 273 (leave/cleanup)
lib/airc_bash/platform_adapters.sh 176 (proc_/port_/file_ adapters)
lib/airc_bash/cmd_status.sh 170 (introspection)
lib/airc_bash/cmd_update.sh 148 (release info)
lib/airc_bash/cmd_rename.sh 121 (name change w/ multi-scope propagation)
lib/airc_bash/cmd_kick.sh 82 (host-only peer eviction)
lib/airc_bash/cmd_reminder.sh 46 (idle-nudge cadence)
```

What remains in airc top-level (1663 lines):

• bootstrap (lib-dir resolver, env, source-blocks)
• helpers (die, ensure_init, get_/set_config_val, resolve_name, relay_ssh, get_host, monitor + self-heal, _hash, …)
• dispatch `case` + help text

Verification

• `bash -n` clean on all files
• `airc help` / `airc version` / `airc reminder` / `airc channel` dispatch correctly
• `test/integration.sh tabs`: 19/0 passing — full join + send + send-file + queue + rename + peers flow under harness

Why this matters

Closes the structural decomposition Joel called for 2026-04-27:

"shell scripts are like classes; never ever again make 5000 line dumbass designs."

The bash monolith is gone. Future passes should decompose `cmd_connect.sh` internally (host-mode vs joiner-mode vs heartbeat are clearly separable) — the 1379-line connect file is now the single largest remaining block. But cmd_connect.sh's internal split is a different shape of work (intra-cmd refactor) than this Phase 3 file split (file-per-cmd).

Stack

Stacks alongside merged #213, #214, #215, #216, #217, #218, #219, #220.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Final Phase 3 of the bash monolith split: moves the remaining cmd_* groups (reminder, rename, update/channel/version) out of the top-level airc script into sourced modules under lib/airc_bash/, keeping airc focused on bootstrap/helpers/dispatch.

Changes:

• Added new sourced bash modules: cmd_reminder.sh, cmd_rename.sh, cmd_update.sh.
• Removed inline implementations of those commands from airc and replaced them with lib-dir-resolved source blocks.
• Kept dispatch behavior the same while reducing the top-level script size.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
lib/airc_bash/cmd_update.sh	New module for update/channel/version command cluster.
lib/airc_bash/cmd_rename.sh	New module for rename + multi-scope propagation logic.
lib/airc_bash/cmd_reminder.sh	New module for reminder interval control.
airc	Removes inline cmd implementations and sources the new modules via _airc_lib_dir.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

cmd_channel writes the provided channel name straight to $dir/.channel without trimming/validation or checking that $dir exists. With set -e, a missing directory will terminate the whole CLI via redirection failure, and whitespace/newlines in the name will later be stripped by cmd_update (surprising mismatch). Consider validating the name (non-empty, no leading -, no whitespace), and fail via die with a clear message if the install dir or .git checkout isn’t present.

Suggested change

	echo "$target" > "$channel_file"
	[ -d "$dir" ] || die "Install directory not found: $dir"
	[ -d "$dir/.git" ] || die "Install directory is not a git checkout: $dir"
	case "$target" in
	"" ) die "Usage: airc channel <name>" ;;
	-* ) die "Invalid channel name '$target': channel names must not start with '-'" ;;
	*[[:space:]]* ) die "Invalid channel name '$target': channel names must not contain whitespace" ;;
	esac
	printf '%s\n' "$target" > "$channel_file"

[Copilot]

The arg parser silently ignores any unrecognized arguments (*) shift ;;). That can hide typos (e.g., airc update --chanel canary) and makes it hard to detect user error. Since cmd_update doesn’t accept positional args, consider dieing on any unknown token (or at least any unknown -* flag) with a usage hint.

Suggested change

	*) shift ;;
	*)
	die "Unknown argument: $1. Usage: airc update [--channel <name> | --canary | --main]"
	;;

[Copilot]

git checkout -q "$channel" can misinterpret a channel name that begins with - as an option. Since channel is user-controlled (CLI arg / .channel file), add a -- end-of-options marker (and ideally validate/sanitize the channel string, e.g. git check-ref-format --branch, or reject leading -) before passing it to git.