Add a patch for WhosOnline

[DanielWTQ]

Special:WhosOnline navigation building was broken due to the removal of IndexPager::buildPrevNextNavigation() from core, and the limit handling was problematic because it always forced the display to have the default limit instead of allowing users to configure it.

[github-actions]

🐳 The image based on 70f41d62 commit has been built with 1.43.5-20251204-556 tag as ghcr.io/canastawiki/canasta:1.43.5-20251204-556

[yaronkoren]

@DanielWTQ - sorry, I somehow missed this before. The fix to get patches working is definitely useful. And obviously this is a needed fix to WhosOnline. But did you try getting this change into the main extension code? I would think someone there would be concerned, knowing that their extension has been broken for two years...

[yaronkoren]

I added an "incompatible" tag to the WhosOnline documentation, by the way: https://www.mediawiki.org/wiki/Extension:WhosOnline

[DanielWTQ]

@DanielWTQ - sorry, I somehow missed this before. The fix to get patches working is definitely useful. And obviously this is a needed fix to WhosOnline. But did you try getting this change into the main extension code? I would think someone there would be concerned, knowing that their extension has been broken for two years...

I have had some bad experiences with the gerrit interface (outside of wikimedia stuff) and didn't create an account for the wikimedia instance. But, no objection to uploading this with https://www.mediawiki.org/wiki/Gerrit_patch_uploader on my behalf

Even if it is on gerrit, if we don't use the patch feature then we need to wait for

• patch to be merged to master
• patch to be backported to REL1_43 (and merged)
• RecommendedRevisions to be updated
• version of RecommendedRevisions used here to be updated

and until then I think adding the patch here is still helpful

I added an "incompatible" tag to the WhosOnline documentation, by the way: https://www.mediawiki.org/wiki/Extension:WhosOnline

Thanks

[tosfos]

A broken extension is an urgent issue because it contradicts a primary goal of Canasta - a stable platform vetted by the community. I'll merge this and we should follow up with the extension authors.

[yaronkoren]

Great. In the meantime, I created a patch for WhosOnline - it required a few more changes, in order to pass validation:

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WhosOnline/+/1217249

I don't think this necessarily needs to be merged in to REL1_43 - it seems like it would be fine to just switch Canasta to use the master branch. Though backporting the patch to the all the REL branches (1_41 and higher) seems like a good idea anyway.