Skip to content

fix: do not remove allowed folder class from definition by reference #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 6.9
Choose a base branch
from
Open

fix: do not remove allowed folder class from definition by reference #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion bundles/AdminBundle/Resources/public/js/pimcore/object/tags/manyToManyRelation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,11 @@ pimcore.object.tags.manyToManyRelation = Class.create(pimcore.object.tags.abstra
this.fieldConfig.classes = this.fieldConfig.classes.filter(function (x) {
if(x.classes == 'folder') {
this.dataObjectFolderAllowed = true;
return false;
// Pimcore returns false, why ?
// in this case the "folder" is removed from the allowed classes by reference
// and if a new field collection is created without a new request for the field collection definition
// it is missing and its not possible to drag and drop folders
return true;
}
return true;
}.bind(this));
Expand Down