Update snake_case Python sample redirects#276
Conversation
|
Should be merged after Cantera/cantera-example-data#5 and Cantera/cantera#1951. |
|
I believe this is ready to be reviewed/merged. |
speth
left a comment
speth
left a comment
There was a problem hiding this comment.
In addition to the present set of rules, which resolve issues with external links once 3.2 becomes stable, there some additional rules to add that will allow the version switcher to work when you're on one of the corresponding pages, since it just looks for the same URL with the version path element changed. I'll push a commit with what I think would work for these rules.
| RewriteRule "^examples/jupyter/reactors/interactive_path_diagram.ipynb.html" "stable/examples/python/kinetics/interactive_path_diagram.html" [R=permanent,L] | ||
| RewriteRule "^examples/jupyter/reactors/nonideal_shock_tube.ipynb.html" "stable/examples/python/reactors/NonIdealShockTube.html" [R=permanent,L] | ||
| RewriteRule "^examples/jupyter/reactors/nonideal_shock_tube.ipynb.html" "stable/examples/python/reactors/non_ideal_shock_tube.html" [R=permanent,L] |
There was a problem hiding this comment.
I guess we still have website updates that can't be merged until the next release. "stable" currently points to the 3.1 docs, where these have the IntialCaps names.
mod_rewrite/.htaccess
Outdated
| RewriteRule "^examples/jupyter.*" "stable/examples/python/index.html" [R=permanent,L] | ||
|
|
||
| # Redirect from CamelCase to snake_case examples | ||
| RewriteRule "^stable/examples/python/reactors/NonIdealShockTube.html$" "stable/examples/python/reactors/non_ideal_shock_tube.html" [R=permanent,L] |
There was a problem hiding this comment.
Likewise these redirects should only be active after the Cantera 3.2 release.
|
Merging this now that 3.2.0 is released. |
2 participants
See Cantera/cantera#1951 (comment)
Also, closes #273