Support setting the energy levels with yaml input file for electron-energy-distribution type: Boltzmann-two-term#2080
Open
BangShiuh wants to merge 2 commits intoCantera:mainfrom
Open
Support setting the energy levels with yaml input file for electron-energy-distribution type: Boltzmann-two-term#2080BangShiuh wants to merge 2 commits intoCantera:mainfrom
BangShiuh wants to merge 2 commits intoCantera:mainfrom
Conversation
…updateElectronEnergyDistribution() to prevent error using the EEDF solver without a collision
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2080 +/- ##
==========================================
+ Coverage 77.21% 77.34% +0.13%
==========================================
Files 456 451 -5
Lines 52952 52500 -452
Branches 8966 8850 -116
==========================================
- Hits 40885 40606 -279
+ Misses 9041 8917 -124
+ Partials 3026 2977 -49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title, the energy levels can be set with the yaml file for type Boltzmann-two-term. Setting the energy levels had no effect before in yaml file, and PlasmaPhase used only the default energy-levels. (The EEDF solver still use the default energy levels regardless.). One issue was that the initiation of the EEDF solver was not completed (it requires the collision cross-sections) at setting the energy levels. The update energy distribution function was triggered by setting the energy levels, and the EEDF solver failed. Therefore, the update energy distribution function cannot run when EEDF solver is not ready. One way is to check the number of collisions to know if the collisions have been loaded. Alternative is to add a function in EEDF solver to signal if it is ready.
Note that the example data is also being updated accordingly, Cantera/cantera-example-data#7. We can first merge this and the example nanosecond_pulse_discharge.py should pass. (The example should also pass without the source code change as the energy-levels data is not used at all.)
@speth @mquiram
If applicable, fill in the issue number this pull request is fixing
Closes #
If applicable, provide an example illustrating new features this pull request is introducing
AI Statement (required)
Limited use of generative AI
Mostly on the test data and comments.
Checklist
scons build&scons test) and unit tests address code coverage