wheel: Bump to C++20 std in CMake config#2082
wheel: Bump to C++20 std in CMake config#2082bryanwweber wants to merge 1 commit intoCantera:mainfrom
Conversation
|
The macOS build is failing the tests for 3.14 on the |
|
Thanks @ischoegl but I'm not sure if this change is sufficient, since the tests are failing for macOS 😭 |
|
Can we adjust that workflow to upload the wheel files (as GitHub artifacts) before running the test suite? That would allow us to download and do some testing locally. I don't think any similar issue has appeared on the main repo's CI, which tests what is nominally the same configuration (Python 3.14 and macOS 15). |
|
I have two thoughts:
|
|
Here's the build artifacts for macOS: https://github.com/Cantera/pypi-packages/actions/runs/21801842231/artifacts/5423630654 from this run https://github.com/Cantera/pypi-packages/actions/runs/21801842231 @speth And I attached them to the comment too: cibw-wheels-macOS-3.1.zip |
|
Thanks, @bryanwweber. I tried the Python 3.14 wheel locally in both Conda and uv environments, and had no trouble running the test suite, so I'm really not sure what the issue is running in CI. Here are the package versions installed in each environment: uvCondaI haven't checked to see if there are any notable differences to the CI environment, but I'm not sure what they would be. The only slightly weird thing I have locally is that uv really wants to install Python 3.14.0rc2 rather than a more recent minor release. |
|
On the python side, the |
Changes proposed in this pull request
The job showing this change is sufficient is
herein the PyPI packages repo.AI Statement (required)
assistance.
Checklist
scons build&scons test) and unit tests address code coverage