Skip to content

Updates to make HP queries return values instead of failing for higher pressures#2087

Open
wandadars wants to merge 1 commit intoCantera:mainfrom
wandadars:cubic_eos_high_pressure
Open

Updates to make HP queries return values instead of failing for higher pressures#2087
wandadars wants to merge 1 commit intoCantera:mainfrom
wandadars:cubic_eos_high_pressure

Conversation

@wandadars
Copy link
Contributor

I was running a test case for a 1D counterflow diffusion flame at very high pressures using the Peng-Robinson equation of state, and the initial condition that used the HP equilibrate call return EoS failures. Codex 5.3 identified this as a possible reason for why the real/ideal gas mixed PREOS might be failing, and it did resolve the EoS that was happening for high pressure H-P equilibrate calls.

AI Statement (required)

  • Extensive use of generative AI.
    Significant portions of code or documentation were generated with AI, including
    logic and implementation decisions. All generated code and documentation were
    reviewed and understood by the contributor. Examples: Output from agentic coding
    tools and/or substantial refactoring by LLMs (web-based or local).

For additional information on Cantera's AI policy, see
https://github.com/Cantera/cantera/blob/main/CONTRIBUTING.md#restrictions-on-generative-ai-usage -->

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 63.82979% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.46%. Comparing base (f49df44) to head (dfa7d20).
⚠️ Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
src/thermo/PengRobinson.cpp 66.66% 4 Missing and 3 partials ⚠️
src/thermo/RedlichKwongMFTP.cpp 66.66% 4 Missing and 3 partials ⚠️
src/thermo/MixtureFugacityTP.cpp 40.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2087      +/-   ##
==========================================
+ Coverage   77.34%   77.46%   +0.11%     
==========================================
  Files         451      451              
  Lines       52494    52791     +297     
  Branches     8847     8843       -4     
==========================================
+ Hits        40602    40895     +293     
- Misses       8917     8920       +3     
- Partials     2975     2976       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant