Skip to content

Fix null reference bug in serializer #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix null reference bug in serializer #10

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4ffd957
Maintain a null key by doing a substitution
honestegg Nov 15, 2012
561fb43
Revert "Maintain a null key by doing a substitution"
honestegg Nov 15, 2012
2b08343
Maintain a null key by doing a substitution
honestegg Nov 15, 2012
37b9df6
Revert "Maintain a null key by doing a substitution"
honestegg Feb 5, 2013
fa381dc
Revert "Revert "Maintain a null key by doing a substitution""
honestegg Feb 5, 2013
c499987
Revert "Revert "Revert "Maintain a null key by doing a substitution"""
honestegg Feb 6, 2013
e00a909
Merge remote-tracking branch 'upstream/master'
honestegg Feb 6, 2013
3e5ddcc
Fix null reference bug in serializer
honestegg Feb 6, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/Elmah.MongoDB/NameValueCollectionSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,18 +57,17 @@ public override void Serialize(
IBsonSerializationOptions options
)
{
if (value == null)
var nvc = value as NameValueCollection;
if (nvc == null)
{
bsonWriter.WriteNull();
return;
}

var nvc = (NameValueCollection)value;

bsonWriter.WriteStartArray();
foreach (var key in nvc.AllKeys)
{
foreach (var val in nvc.GetValues(key))
foreach (var val in nvc.GetValues(key) ?? new string[0])
{
bsonWriter.WriteStartArray();
StringSerializer.Instance.Serialize(bsonWriter, typeof(string), key, options);
Expand Down