Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
codex/**) and reduce friction when triggering the remote build from local shells.GITHUB_REPO/GITHUB_REFwhen possible to avoid manual errors./conditionsendpoint) and include necessary frontend packaging/config files for Capacitor.Description
.github/workflows/android-apk.ymlto trigger onworkflow_dispatch, tag pushesv*and pushes tomain,work, andcodex/**so branches likecodex/paraweatherbuild the APK.frontend/scripts/trigger_github_apk.shto auto-detectGITHUB_REPOfromgit remote originandGITHUB_REFfrom the current branch when those environment variables are not provided, while keeping theGITHUB_TOKENguard.README.mdto document the new triggers, examples targetingcodex/paraweather, and clarified the CLI/PowerShell usage and auto-detection behavior.backend/server.pyinclude safer MongoDB env handling and client options, added/adjusted Pydantic models (RouteSegment.altitude_status,FlightCondition), new helper functions (classify_altitude_status,weather_code_to_text,compute_flight_score), and a new API endpointGET /api/conditionsthat returns a flight recommendation and score.frontend/capacitor.config.tsand updated frontend packaging artifacts (package-lock.jsonand other frontend files in previous diffs) to prepare the project for Capacitor/Android packaging.Testing
bash -n frontend/scripts/trigger_github_apk.shto validate the trigger script syntax, which passed. — OKpython -c "import json;json.load(open('frontend/package.json'));print('package ok')"to validatefrontend/package.jsonpresence/parseability, which printedpackage ok. — OKrgforcodex/**,GITHUB_REF, andGITHUB_REPOoccurrences to confirm documentation and workflow alignment. — OKfrontend/scripts/trigger_github_apk.shend-to-end in this environment and it exited with a clear error due to missingGITHUB_TOKEN, which is expected (the script intentionally requires a token). — EXPECTED FAILURECodex Task