Add kryo support [2/2] #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use mcpu=cortex-a57, since it is the closest to Kryo. * Clang doesn't support Kryo as a target yet. Bug: 36728278 Test: Built and booted a sailfish using Kryo. Change-Id: Ic0c9588d86fba41896e50e3f0cf0d2b310ffee93 Signed-off-by: Alex Naidis <alex.naidis@linux.com>
* Kryo is closer to Krait than to cortex-a53, so choose Krait defaults. * Made together with Jake Weinstein (xboxfanj) Bug: 36728278 Test: Built and boot sailfish set up as kryo. Change-Id: I04fa0a1dca6f97ae19202d28ee3ce8a59bf169b5 Signed-off-by: Alex Naidis <alex.naidis@linux.com>
* -mfpu=neon-fp-armv8 enables the ARMv8 floating-point and Advanced SIMD extensions. Test: Marlin builds successfully Change-Id: Ibdf71dae61b966372e3bcb946aa18d1a6cd0f8e6
Clang supports specific CPU targeting and optimization for Kryo. This switches us to using the specific Kryo targeting when Clang is used. For other compilers, we fallback to cortex-a57 targeting. Also, move the replaceFirst function to a shared location. Bug: 36728278 Test: Built and booted sailfish, ran bionic unit tests and art tests. Test: Disassembled libc.so before this change and after and looked at Test: the differences. Mostly the results were the order of instructions Test: changing. Test: Verified with the clang person (srhines) that our clang has this support Test: and that it appears to be mostly instruction scheduling changes. Change-Id: I4ee73d8bcc1e4f5eccb162c18937811fe199b16f Signed-off-by: Alex Naidis <alex.naidis@linux.com>
Current modules must use armv7_a_neon to specify source files that compile only with neon. If a future arch variant also supports neon, all these modules will fall back to non-neon. Support a neon arch feature that modules can use instead. Similarly, support dspr2 for mips. arm_device.go was also mixing armv7-a-neon with armv7_a_neon. Use armv7-a-neon consistently, and fix the - to _ when creating the property structs. Test: m -j checkbuild Change-Id: I24d3764280ab3bcbb9a73c0934edc9b99fc7f6a0
Also, update flags for cortex-a53. Bug: 37647380 Test: Built target with cortex-a73 for both 32 bit/64 bit. Test: Built target with cortex-a53.cortex-a57 for both 32 bit/64 bit. Test: Ran bionic unit tests, ran art target tests. (cherry picked from commit 1d9aa26) Change-Id: I3325f60add7f424f8cca53c22919fc481ef5e787
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.