Conversation
PabloDinella
requested changes
Jan 5, 2026
Collaborator
PabloDinella
left a comment
PabloDinella
left a comment
There was a problem hiding this comment.
I think most of the new logic in FamilyScreen.tsx could go in a separate file, and be called from the AdultCard instead of FamilyScreen, could you make this change?
Also, I think you don't need a state for person id, you can reference the person id directly from the props instead of saving it on a state. Probably the same for CompleteOtherContext.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ‘Complete Other’ option was added to the volunteer card. When the 3 dots are clicked, a popup opens with an autocomplete, a Cancel button, and a Complete/Exempt button, a requirement (action) can be selected from the autocomplete and then completed or exempted.