-
-
Notifications
You must be signed in to change notification settings - Fork 0
iOS publish #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kmsalah
wants to merge
11
commits into
master
Choose a base branch
from
iosPublish
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
iOS publish #28
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c696902
set deployment to get games_services
kmsalah a4eb882
updates pods
kmsalah 5144eb8
working version, pulls games up fine unless there are image issues //…
kmsalah 7a1eb12
merge from master
kmsalah 72b0107
Gkplayer patch
kmsalah 0c225f1
games services is working, ios achievement added
kmsalah e46903f
front page more responsive for bigger screens
kmsalah eaa48de
responsive gamescreen
kmsalah 6e82142
cleaned up, responsive gamescreen is up
kmsalah db9ce41
uni linking to app is working
kmsalah d564fde
submitted for review
kmsalah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
|
|
||
| .svg-icon { | ||
| position:relative; | ||
| bottom: -10px; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,17 @@ | ||
| # CarolinaIgnites | ||
|
|
||
| [CarolinaIgnites](https://www.carolinaignites.org) started as a group at the University of South Carolina, after receive Google's IgniteCS funding for 2017. Every year then, CarolinaIgnites has put on workshops aimed at high-school students or those trying to learn computer science. This app is a way of showcasing and playing the games you've made using our [editor](https://editor.carolinaignites.org). This app is **not** meant as a distribution or publishing platform, but just a way to play a few fun games. | ||
| [CarolinaIgnites](https://www.carolinaignites.org) started as a group at the University of South Carolina, after receiving Google's IgniteCS funding for 2017. Every year then, CarolinaIgnites has put on workshops aimed at high-school students or those trying to learn computer science. This app is a way of showcasing and playing the games you've made using our [editor](https://editor.carolinaignites.org). This app is **not** meant as a distribution or publishing platform, but just a way to play a few fun games. | ||
|
|
||
| Try out some of the more popular games, our scan the QR code on the editor to try your own. Favorited games will be saved to your device for offline usage. | ||
|
|
||
|
|
||
| Check out the [CarolinaIgnites coding editor ](https://editor.carolinaignites.org) to create and player your own games. | ||
|
|
||
| For more information and documentation: | ||
| - https://github.com/CarolinaIgnites/gameFrame | ||
| - https://carolinaignites.org | ||
|
|
||
|
|
||
|
|
||
| Try out some of the more popular games, our scan the QR code on the editor to try your own. Favourited games will be saved to your device for offline usage. | ||
|
|
||
| Don't be shy! Email us, [hello@carolinaignites.org](mailto:hello@carolinaignites.org) | ||
Binary file added
BIN
+140 KB
...creen Shot - iPad Pro (12.9-inch) (4th generation) - 2020-05-25 at 15.44.56.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+134 KB
...creen Shot - iPad Pro (12.9-inch) (4th generation) - 2020-05-25 at 15.45.06.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+170 KB
...creen Shot - iPad Pro (12.9-inch) (4th generation) - 2020-05-25 at 15.48.23.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+4.07 MB
...creen Shot - iPad Pro (12.9-inch) (4th generation) - 2020-05-25 at 15.52.48.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+186 KB
...creen Shot - iPad Pro (12.9-inch) (4th generation) - 2020-05-25 at 15.52.58.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+197 KB
...creen Shot - iPad Pro (12.9-inch) (4th generation) - 2020-05-25 at 15.53.51.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+261 KB
...creen Shot - iPad Pro (12.9-inch) (4th generation) - 2020-05-25 at 15.53.55.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+145 KB
...eenshots/Simulator Screen Shot - iPhone 11 Pro Max - 2020-05-18 at 19.40.42.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+145 KB
...eenshots/Simulator Screen Shot - iPhone 11 Pro Max - 2020-05-18 at 20.01.02.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+125 KB
...eenshots/Simulator Screen Shot - iPhone 11 Pro Max - 2020-05-18 at 20.01.24.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.22 MB
...eenshots/Simulator Screen Shot - iPhone 11 Pro Max - 2020-05-18 at 20.04.33.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+121 KB
...eenshots/Simulator Screen Shot - iPhone 11 Pro Max - 2020-05-18 at 20.05.09.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+113 KB
...eenshots/Simulator Screen Shot - iPhone 11 Pro Max - 2020-05-18 at 20.32.04.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+270 KB
...eenshots/Simulator Screen Shot - iPhone 11 Pro Max - 2020-05-18 at 20.32.09.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+269 KB
...eenshots/Simulator Screen Shot - iPhone 11 Pro Max - 2020-05-18 at 20.33.23.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+329 KB
...eenshots/Simulator Screen Shot - iPhone 11 Pro Max - 2020-05-18 at 21.33.55.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+149 KB
...eenshots/Simulator Screen Shot - iPhone 11 Pro Max - 2020-05-25 at 16.04.21.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+129 KB
.../screenshots/Simulator Screen Shot - iPhone 8 Plus - 2020-05-22 at 20.29.55.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+128 KB
.../screenshots/Simulator Screen Shot - iPhone 8 Plus - 2020-05-25 at 16.06.03.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+97 KB
.../screenshots/Simulator Screen Shot - iPhone 8 Plus - 2020-05-25 at 16.06.12.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+65.9 KB
.../screenshots/Simulator Screen Shot - iPhone 8 Plus - 2020-05-25 at 16.06.20.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+97.9 KB
.../screenshots/Simulator Screen Shot - iPhone 8 Plus - 2020-05-25 at 16.07.01.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+319 KB
.../screenshots/Simulator Screen Shot - iPhone 8 Plus - 2020-05-25 at 16.07.04.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+258 KB
assets/screenshots/Simulator Screen Shot - iPhone 8 Plus - AboutUs.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+66 KB
assets/screenshots/Simulator Screen Shot - iPhone 8 Plus - GamePlayScreen.png
Oops, something went wrong.
Binary file added
BIN
+135 KB
assets/screenshots/Simulator Screen Shot - iPhone 8 Plus - Homescreen.png
Oops, something went wrong.
Binary file added
BIN
+100 KB
assets/screenshots/Simulator Screen Shot - iPhone 8 Plus -PlayGameScreen.png
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| { | ||
|
|
||
| document.documentElement.style.margin = "0"; | ||
| document.documentElement.style.height = "100%"; | ||
| document.documentElement.style.overflow = "hidden"; | ||
|
|
@@ -10,8 +11,11 @@ | |
| document.body.style.position = "fixed"; | ||
| document.body.style.backgroundColor = "black"; | ||
|
|
||
| document.querySelector("#container").innerHTML = window.atob(`{{{html}}}`); | ||
| var node = document.createElement("DIV"); // Create a <li> node | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Clean up comments + make DIV -> div |
||
| node.id = "container"; // Append the text to <li> | ||
| document.body.appendChild(node); // Append <li> to <ul> with id="myList" | ||
|
|
||
| document.querySelector("#container").innerHTML = window.atob(`{{{html}}}`); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would set innerHTML prior to appending to page |
||
| const CODE = window.atob(`{{{code}}}`); | ||
| const META = (function() { | ||
| let image_lookup = JSON.parse(window.atob(`{{{images}}}`)); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,10 @@ | ||
| #!/bin/sh | ||
| # This is a generated file; do not edit or check into version control. | ||
| export "FLUTTER_ROOT=/home/dylan/src/flutter" | ||
| export "FLUTTER_APPLICATION_PATH=/home/dylan/src/arcadeframe" | ||
| export "FLUTTER_ROOT=/Users/khalidsalah/flutter" | ||
| export "FLUTTER_APPLICATION_PATH=/Users/khalidsalah/IgniteCS/arcadeFrame" | ||
| export "FLUTTER_TARGET=lib/main.dart" | ||
| export "FLUTTER_BUILD_DIR=build" | ||
| export "SYMROOT=${SOURCE_ROOT}/../build/ios" | ||
| export "OTHER_LDFLAGS=$(inherited) -framework Flutter" | ||
| export "FLUTTER_FRAMEWORK_DIR=/home/dylan/src/flutter/bin/cache/artifacts/engine/ios" | ||
| export "FLUTTER_FRAMEWORK_DIR=/Users/khalidsalah/flutter/bin/cache/artifacts/engine/ios-release" | ||
| export "FLUTTER_BUILD_NAME=1.0.2" | ||
| export "FLUTTER_BUILD_NUMBER=3" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm haven't tested, but you might have to make these links
[text](link)